Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] Skip all files named .DS_Store, no need to check if the file is regular #13669

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

ras0219
Copy link
Contributor

@ras0219 ras0219 commented Sep 22, 2020

fs::is_regular_file() requires an extra stat call and can fail.

@PhoebeHui PhoebeHui added the category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. label Sep 24, 2020
@ras0219-msft ras0219-msft merged commit ae82a55 into microsoft:master Sep 28, 2020
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants