Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[x264] Fix *inx dynamic build #13684

Merged
merged 4 commits into from
Sep 28, 2020
Merged

Conversation

JackBoosY
Copy link
Contributor

if(VCPKG_LIBRARY_LINKAGE STREQUAL "dynamic")

Since x264 support linux, this condition is incorrect.

Fixes #13683.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Sep 23, 2020
@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Sep 24, 2020
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once merged with master

@JackBoosY
Copy link
Contributor Author

Blocked by #13722.

@JackBoosY
Copy link
Contributor Author

blocked by #13765.

@ras0219-msft ras0219-msft merged commit a8c046b into microsoft:master Sep 28, 2020
@JackBoosY JackBoosY deleted the dev/jack/13683 branch September 28, 2020 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[x264] x64-linux-dynamic install failure
3 participants