Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opensubdiv] New port #13695

Merged
merged 9 commits into from
Oct 9, 2020
Merged

Conversation

ousttrue
Copy link
Contributor

Describe the pull request

What does your PR fix? #5310

Adds a port for the the https://github.com/PixarAnimationStudios/OpenSubdiv

Which triplets are supported/not supported? Have you updated the CI baseline?

Tested x64-Windows.

Does your PR follow the maintainer guide?

Yes

@PhoebeHui
Copy link
Contributor

@ousttrue, thanks for the PR!

The CI failed with following failure, could you format the vcpkg.json file with command

./vcpkg format-manifest ports/opensubdiv/vcpkg.json

Failures:
The formatting of the manifest files didn't match our expectation.
See github.com/microsoft/vcpkg/blob/master/docs/maintainers/maintainer-guide.md#manifest for solution.

@PhoebeHui PhoebeHui added category:new-port The issue is requesting a new library to be added; consider making a PR! requires:author-response labels Sep 24, 2020
ports/opensubdiv/vcpkg.json Outdated Show resolved Hide resolved
ports/opensubdiv/portfile.cmake Outdated Show resolved Hide resolved
./vcpkg format-manifest ports/opensubdiv/vcpkg.json
@PhoebeHui
Copy link
Contributor

@ousttrue, here is the failure for each triplets in CI testing.
install-arm64-windows-dbg-out.log
install-x64-windows-static-rel-out.log
install-x86-windows-dbg-out.log
install-x64-uwp-dbg-out.log

x64-windows-static:
LINK : warning LNK4044: unrecognized option '/openmp'; ignored
libcpmt.lib(wlocale.obj) : error LNK2001: unresolved external symbol _purecall
libcpmt.lib(xlocale.obj) : error LNK2001: unresolved external symbol _purecall
main.cpp.obj : error LNK2001: unresolved external symbol _purecall
libcpmt.lib(locale0.obj) : error LNK2001: unresolved external symbol _purecall
libcpmt.lib(cerr.obj) : error LNK2001: unresolved external symbol _purecall
libcpmt.lib(locale.obj) : error LNK2001: unresolved external symbol _purecall
libcpmt.lib(wlocale.obj) : error LNK2001: unresolved external symbol "void * __cdecl operator new(unsigned __int64)" (??2@YAPEAX_K@Z)
libcpmt.lib(xlocale.obj) : error LNK2001: unresolved external symbol "void * __cdecl operator new(unsigned __int64)" (??2@YAPEAX_K@Z)
main.cpp.obj : error LNK2001: unresolved external symbol "void * __cdecl operator new(unsigned __int64)" (??2@YAPEAX_K@Z)

x86-windows: 
nvcc fatal   : 32 bit compilation is only supported for Microsoft Visual Studio 2013 and earlier
CMake Error at osd_static_gpu_generated_cudaKernel.cu.obj.Debug.cmake:220 (message):

arm64-windows:
This version of D:\buildtrees\opensubdiv\arm64-windows-dbg\bin\stringify.exe is not compatible with the version of Windows you're running. Check your computer's system information and then contact the software publisher.

arm-uwp and x64-uwp:
error C3861: 'LoadLibraryW': identifier not found

@ousttrue
Copy link
Contributor Author

👍

Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

ports/opensubdiv/vcpkg.json Outdated Show resolved Hide resolved
ports/opensubdiv/portfile.cmake Show resolved Hide resolved
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
@ousttrue
Copy link
Contributor Author

I'm not sure about targets other than x64-windows...

@ousttrue
Copy link
Contributor Author

static build fixed.

CI x86_windows #13722

@ras0219-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Sep 30, 2020
@dan-shaw
Copy link
Contributor

dan-shaw commented Oct 6, 2020

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@BillyONeal BillyONeal merged commit 956f73a into microsoft:master Oct 9, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants