Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lerc] Export Package #13724

Merged
merged 4 commits into from
Oct 9, 2020
Merged

[lerc] Export Package #13724

merged 4 commits into from
Oct 9, 2020

Conversation

n4z4m3
Copy link
Contributor

@n4z4m3 n4z4m3 commented Sep 24, 2020

Fixes #13723

The lerc library does not export a package which makes it difficult to use in other CMake projects.

This PR creates a patch to the CMakeLists.txt file to export a package.

@LilyWangL LilyWangL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Sep 25, 2020
@LilyWangL
Copy link
Contributor

Blocked by #13722.

Copy link
Contributor Author

@n4z4m3 n4z4m3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with these changes

@n4z4m3
Copy link
Contributor Author

n4z4m3 commented Sep 25, 2020

I am seeing that the CI x86_windows is failing, however, when I run it locally, it works fine.

@ras0219-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Sep 30, 2020
@dan-shaw
Copy link
Contributor

dan-shaw commented Oct 6, 2020

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@dan-shaw
Copy link
Contributor

dan-shaw commented Oct 6, 2020

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@n4z4m3
Copy link
Contributor Author

n4z4m3 commented Oct 9, 2020

Any ideas why the checks are not getting through?

@BillyONeal BillyONeal merged commit 95c0643 into microsoft:master Oct 9, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lerc] Does not create a package
6 participants