Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ashes] Add new port. #14087

Merged
merged 7 commits into from
Oct 23, 2020
Merged

[ashes] Add new port. #14087

merged 7 commits into from
Oct 23, 2020

Conversation

DragonJoker
Copy link
Contributor

@DragonJoker DragonJoker commented Oct 16, 2020

Describe the pull request

  • What does your PR fix?
    Fixes [New Port Request] ashes #13893 .

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    UWP, iOS and Android are not supported. x86 and arm platforms are unsupported.
    I have tested x64-windows, x64-linux and x64-osx, and Ashes doesn't support static library linkage.
    The CI baseline has been updated.

  • Does your PR follow the maintainer guide?
    Yes.

@ghost
Copy link

ghost commented Oct 16, 2020

CLA assistant check
All CLA requirements met.

@LilyWangL LilyWangL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Oct 19, 2020
ports/ashes/portfile.cmake Outdated Show resolved Hide resolved
ports/ashes/portfile.cmake Outdated Show resolved Hide resolved
ports/ashes/vcpkg.json Show resolved Hide resolved
@LilyWangL LilyWangL added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Oct 22, 2020
ports/ashes/portfile.cmake Outdated Show resolved Hide resolved
@BillyONeal BillyONeal merged commit 3048968 into microsoft:master Oct 23, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] ashes
3 participants