Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg baseline][qca] Re-fix find pkgconfig using FindPkgConfig.cmake #14110

Merged
merged 1 commit into from
Oct 19, 2020
Merged

[vcpkg baseline][qca] Re-fix find pkgconfig using FindPkgConfig.cmake #14110

merged 1 commit into from
Oct 19, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Oct 19, 2020 •
edited
Loading

Continue PR #14058, use the FindPkgConfig.cmake fixed by cmake to solve the issue of finding the pkg-config script in perl in Windows (fixed by PR https://gitlab.kitware.com/cmake/cmake/-/merge_requests/5273).

Current configure result:

CMake Error at D:/downloads/tools/cmake-3.18.2-windows/cmake-3.18.2-win32-x86/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:165 (message):
  Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE)

      Reason given by package: The command
        "D:/downloads/tools/perl/5.30.0.1/perl/bin/pkg-config" --version
      failed with output
        

Call Stack (most recent call first):
  D:/downloads/tools/cmake-3.18.2-windows/cmake-3.18.2-win32-x86/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:458 (_FPHSA_FAILURE_MESSAGE)
  D:/downloads/tools/cmake-3.18.2-windows/cmake-3.18.2-win32-x86/share/cmake-3.18/Modules/FindPkgConfig.cmake:59 (find_package_handle_standard_args)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:530 (_find_package)
  plugins/qca-nss/CMakeLists.txt:1 (find_package)

Fixed configure results:

-- Found PkgConfig: F:/vcpkg/downloads/tools/perl/5.30.0.1/perl/bin/pkg-config.bat (found version "0.26")

Related: #12612.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Oct 19, 2020
@JackBoosY JackBoosY changed the title [qca] Re-fix find pkgconfig using FindPkgConfig.cmake [vcpkg baseline][qca] Re-fix find pkgconfig using FindPkgConfig.cmake Oct 19, 2020
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Oct 19, 2020
JackBoosY
JackBoosY commented Oct 19, 2020
View reviewed changes
ports/qca/portfile.cmake
SHA512 d9aada8107eac9ada197d0b1e9040cd3707de7f5838c90bca80321e8eb35931f520635800bea0e2aafeca7fafb08b8e4752d5c6c2d6b1a5d5b4e3225d7818aa6
)
vcpkg_download_distfile(ARCHIVE_PKGHSA
URLS "https://gitlab.kitware.com/cmake/cmake/-/raw/ab8bd48352df060c4ead210fe30dc4736646206b/Modules/FindPackageHandleStandardArgs.cmake?inline=false"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required by FindPkgConfig.cmake.

JackBoosY
JackBoosY commented Oct 19, 2020
View reviewed changes
ports/qca/portfile.cmake
)
vcpkg_download_distfile(ARCHIVE_PKGMSG
URLS "https://gitlab.kitware.com/cmake/cmake/-/raw/ab8bd48352df060c4ead210fe30dc4736646206b/Modules/FindPackageMessage.cmake?inline=false"
FILENAME "FindPackageMessage.cmake"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required by FindPackageHandleStandardArgs.cmake.

@BillyONeal BillyONeal merged commit bb7d4f2 into microsoft:master Oct 19, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

@Jimmy-Hu Jimmy-Hu mentioned this pull request Oct 20, 2020
Merged
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Oct 20, 2020
@Jimmy-Hu
Merge pull request #361 from microsoft/master
ef2d813 
[qca] Re-fix find pkgconfig using FindPkgConfig.cmake (microsoft#14110)
@JackBoosY JackBoosY deleted the dev/jack/fix_qca_pkgconfig branch October 20, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackBoosY @BillyONeal @PhoebeHui