Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] Vcpkg appinstall deps fixes #14129

Merged
merged 2 commits into from
Oct 22, 2020

Conversation

sandercox
Copy link
Contributor

@sandercox sandercox commented Oct 20, 2020

@Shatur95 mentioned in issue #1653 that he was missing _install if install is not overriden with a custom function than _install will not be found so we should refer to install in this function

Also I was prefixing the ${CMAKE_INSTALL_PREFIX} in my custom install override but as @Shatur95 points out it makes more sense to do that in the vcpkg.cmake file.

This is a continuation/bugfix on #13011

@Shatur
Copy link
Contributor

Shatur commented Oct 20, 2020

Thank you, it works for me even with CPack.

Maybe introduce an option to override install command as it was made originally?

@LilyWangL LilyWangL self-assigned this Oct 21, 2020
@LilyWangL LilyWangL added the category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) label Oct 21, 2020
@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Oct 21, 2020
@BillyONeal
Copy link
Member

Thanks for the review @ras0219

@BillyONeal BillyONeal merged commit 4a11bdd into microsoft:master Oct 22, 2020
@BillyONeal
Copy link
Member

@sandercox Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants