[vcpkg] X_VCPKG_APPINSTALL_DEPS_INSTALL optionally install dependencies on install #14243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shatur
suggested changes
Oct 26, 2020
There was a problem hiding this comment.
Works as expected for me with install command and CPack.
One small suggestion: you don't need to expand variables in if expressions, this will be done automatically. Elsewhere in this file, the same approach is used, so it's best to do the same for consistency. :) I also tested with this changes, everything works fine for me.
PhoebeHui
added
the
category:vcpkg-feature
Use variables directly instead of prefixing with `${}` as is done in rest of the file. Thanks @shatur95
Co-authored-by: Hennadii Chernyshchyk <genaloner@gmail.com>
Co-authored-by: Hennadii Chernyshchyk <genaloner@gmail.com>
Shatur
approved these changes
Oct 29, 2020
|
cc @BillyONeal for review this PR. |
|
Given that this is an experimental feature, I'm up for merging it, with the understanding that this very well may be removed or modified, especially as we get closer to stabilization :) Thanks @sandercox for your contribution~! |
huangjj852
added a commit
to huangjj852/vcpkg
that referenced
this pull request
Dec 7, 2020
…pendencies on install (microsoft#14243)" This reverts commit 42456b7.
huangjj852
added a commit
to huangjj852/vcpkg
that referenced
this pull request
Dec 7, 2020
…stall dependencies on install (microsoft#14243)"" This reverts commit 062f105.
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on the work from #14129 #13011 this adds an install command override again as proposed initially but behind an
ifcheck for the variableX_VCPKG_APPLOCAL_DEPS_INSTALLmarking it as experimental and allowing the feature to just work as I initially intended.I was already using the install function as used here in my own projects but I think this allows everybody to really use the functionality introduced by the
x_vcpkg_install_local_dependenciesfunction.As originally requested in #1653