Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] update msys-libiconv version #14220

Merged
merged 1 commit into from
Oct 26, 2020
Merged

[vcpkg] update msys-libiconv version #14220

merged 1 commit into from
Oct 26, 2020

Conversation

ludchieng
Copy link
Contributor

link to previous version 1.16-1 does not exist anymore

@ludchieng
[vcpkg] update msys-libiconv version
59ea3ff 
link to previous version 1.16-1 does not exist anymore
@fabiencastan
Copy link
Contributor

Fix #14209

@PhoebeHui PhoebeHui self-requested a review October 26, 2020 02:29
@PhoebeHui PhoebeHui self-assigned this Oct 26, 2020
@JackBoosY JackBoosY linked an issue Oct 26, 2020 that may be closed by this pull request
[qt5-base] build failure #14194
Closed
@JackBoosY JackBoosY added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Oct 26, 2020
@PhoebeHui PhoebeHui mentioned this pull request Oct 26, 2020
Closed
This was linked to issues Oct 26, 2020
Mlpack build failure #14216
Closed
msys libiconv missing #14209
Closed
@JackBoosY JackBoosY assigned PhoebeHui and JackBoosY and unassigned PhoebeHui Oct 26, 2020
@PhoebeHui PhoebeHui linked an issue Oct 26, 2020 that may be closed by this pull request
[ICU] build failure #14222
Closed
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Oct 26, 2020
@JackBoosY
Copy link
Contributor

ping @BillyONeal for merge this PR quickly.

@JackBoosY JackBoosY mentioned this pull request Oct 26, 2020
Merged
@BillyONeal
Copy link
Member

:sigh: msys keeps on giving. Thanks for your contribution!

@BillyONeal BillyONeal merged commit ba7fd71 into microsoft:master Oct 26, 2020
@traversaro traversaro mentioned this pull request Oct 26, 2020
Closed
@emptyVoid
Copy link
Contributor

@BillyONeal, as I've mentioned in #13019 MSYS2 is well-known (and states on its site) being a rolling-release repo. There's nothing wrong with MSYS2 here, imo it's just a bad decision on vcpkg part to replace pacman with the direct downloads.

@emptyVoid emptyVoid mentioned this pull request Oct 28, 2020
Closed
@BillyONeal
Copy link
Member

@emptyVoid We replaced pacman with direct downloads because pacman kept failing in a way that hangs the build substantially more often than they just outright delete packages.

@traversaro
Copy link
Contributor

If the MSYS2 project does not provide any period for which old packages are left on the their repos, could it make sense that vcpkg just provide its own mirrors for the files listed in https://github.com/ludchieng/vcpkg/blob/59ea3ff752d5e8415062e9a733eafd927849667e/scripts/cmake/vcpkg_acquire_msys.cmake#L144 ?

mcmtroffaes pushed a commit to mcmtroffaes/vcpkg that referenced this pull request Oct 29, 2020
@ludchieng @mcmtroffaes
[vcpkg] update msys-libiconv version (microsoft#14220)
9f661af 
link to previous version 1.16-1 does not exist anymore
@ludchieng ludchieng deleted the fix_msys_libiconv branch November 5, 2020 13:39
@StarGate-One StarGate-One mentioned this pull request Nov 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

@PhoebeHui PhoebeHui Awaiting requested review from PhoebeHui

Assignees

@PhoebeHui PhoebeHui

@JackBoosY JackBoosY

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ICU] build failure Mlpack build failure msys libiconv missing [qt5-base] build failure
8 participants
@ludchieng @fabiencastan @JackBoosY @BillyONeal @emptyVoid @traversaro @cynoxure @PhoebeHui