Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[abseil] Re-fix cxx 17 standard, add macro ABSL_USE_CXX17 #14647

Merged
merged 3 commits into from Nov 20, 2020
Merged

[abseil] Re-fix cxx 17 standard, add macro ABSL_USE_CXX17 #14647

merged 3 commits into from Nov 20, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Nov 19, 2020 •
edited

  • Combine patch fix-lnk2019-error.patch and fix-use-cxx17-stdlib-types.patch
  • Add the macro ABSL_USE_CXX17 in absl-config.cmake to indicate that absl uses the cxx standard
  • Since I modified the header options.h, add option DISABLE_PARALLEL_CONFIGURE to avoid permission issue
  • Fix grpc cxx 17 standard.

fixes #14609.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Nov 19, 2020
JackBoosY
JackBoosY commented Nov 19, 2020
View reviewed changes
ports/abseil/fix-cxx-standard.patch
Comment on lines +48 to +52
+if (NOT EXISTS ${CMAKE_CURRENT_LIST_DIR}/options.h.in)
+ file(RENAME ${CMAKE_CURRENT_LIST_DIR}/options.h ${CMAKE_CURRENT_LIST_DIR}/options.h.in)
+endif()
+file(REMOVE ${CMAKE_CURRENT_LIST_DIR}/options.h)
+configure_file(${CMAKE_CURRENT_LIST_DIR}/options.h.in ${CMAKE_CURRENT_LIST_DIR}/options.h @ONLY)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support --editable mode.

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Nov 20, 2020
@strega-nil strega-nil merged commit 9b72cad into microsoft:master Nov 20, 2020
@strega-nil
Copy link
Contributor

Thanks @JackBoosY :)

@JackBoosY JackBoosY deleted the dev/jack/14609 branch November 23, 2020 05:29
x-projs pushed a commit to x-projs/vcpkg that referenced this pull request Mar 13, 2021
@JackBoosY @xieyubo
[abseil] Re-fix cxx 17 standard, add macro ABSL_USE_CXX17 (microsoft#…
930a255 
…14647)

* [abseil] Re-fix cxx 17 standard, add macro ABSL_USE_CXX17 to `absl-config.cmake`

* [grpc] Fix build failure when abseil use cxx 17 standard

* Update ports/abseil/portfile.cmake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[grpc] build failure
3 participants
@JackBoosY @strega-nil @PhoebeHui