-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[abseil] Re-fix cxx 17 standard, add macro ABSL_USE_CXX17 #14647
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,96 @@ | ||
diff --git a/CMake/abslConfig.cmake.in b/CMake/abslConfig.cmake.in | ||
index 62d246d..00947cf 100644 | ||
--- a/CMake/abslConfig.cmake.in | ||
+++ b/CMake/abslConfig.cmake.in | ||
@@ -6,3 +6,5 @@ find_dependency(Threads) | ||
@PACKAGE_INIT@ | ||
|
||
include ("${CMAKE_CURRENT_LIST_DIR}/@PROJECT_NAME@Targets.cmake") | ||
+ | ||
+set(ABSL_USE_CXX17 @ABSL_USE_CXX17@) | ||
\ No newline at end of file | ||
diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
index f0af6f6..927f4ed 100644 | ||
--- a/CMakeLists.txt | ||
+++ b/CMakeLists.txt | ||
@@ -57,6 +57,23 @@ else() | ||
option(ABSL_ENABLE_INSTALL "Enable install rule" ON) | ||
endif() | ||
|
||
+# CXX standard | ||
+option(ABSL_USE_CXX17 "Enable CXX 17 standard" OFF) | ||
+ | ||
+if (ABSL_USE_CXX17) | ||
+ set(CMAKE_CXX_STANDARD 17) | ||
+ set(STD_ANY 1) | ||
+ set(STD_OPTIONAL 1) | ||
+ set(STD_STRING_VIEW 1) | ||
+ set(STD_VARIANT 1) | ||
+else() | ||
+ set(CMAKE_CXX_STANDARD 11) | ||
+ set(STD_ANY 0) | ||
+ set(STD_OPTIONAL 0) | ||
+ set(STD_STRING_VIEW 0) | ||
+ set(STD_VARIANT 0) | ||
+endif() | ||
+ | ||
list(APPEND CMAKE_MODULE_PATH | ||
${CMAKE_CURRENT_LIST_DIR}/CMake | ||
${CMAKE_CURRENT_LIST_DIR}/absl/copts | ||
diff --git a/absl/base/CMakeLists.txt b/absl/base/CMakeLists.txt | ||
index 9ff5aa2..315bee4 100644 | ||
--- a/absl/base/CMakeLists.txt | ||
+++ b/absl/base/CMakeLists.txt | ||
@@ -87,6 +87,12 @@ absl_cc_library( | ||
absl::errno_saver | ||
) | ||
|
||
+if (NOT EXISTS ${CMAKE_CURRENT_LIST_DIR}/options.h.in) | ||
+ file(RENAME ${CMAKE_CURRENT_LIST_DIR}/options.h ${CMAKE_CURRENT_LIST_DIR}/options.h.in) | ||
+endif() | ||
+file(REMOVE ${CMAKE_CURRENT_LIST_DIR}/options.h) | ||
+configure_file(${CMAKE_CURRENT_LIST_DIR}/options.h.in ${CMAKE_CURRENT_LIST_DIR}/options.h @ONLY) | ||
+ | ||
absl_cc_library( | ||
NAME | ||
config | ||
diff --git a/absl/base/options.h b/absl/base/options.h | ||
index 6a0fb07..54a9780 100644 | ||
--- a/absl/base/options.h | ||
+++ b/absl/base/options.h | ||
@@ -100,7 +100,7 @@ | ||
// User code should not inspect this macro. To check in the preprocessor if | ||
// absl::any is a typedef of std::any, use the feature macro ABSL_USES_STD_ANY. | ||
|
||
-#define ABSL_OPTION_USE_STD_ANY 2 | ||
+#define ABSL_OPTION_USE_STD_ANY @STD_ANY@ | ||
|
||
|
||
// ABSL_OPTION_USE_STD_OPTIONAL | ||
@@ -127,7 +127,7 @@ | ||
// absl::optional is a typedef of std::optional, use the feature macro | ||
// ABSL_USES_STD_OPTIONAL. | ||
|
||
-#define ABSL_OPTION_USE_STD_OPTIONAL 2 | ||
+#define ABSL_OPTION_USE_STD_OPTIONAL @STD_OPTIONAL@ | ||
|
||
|
||
// ABSL_OPTION_USE_STD_STRING_VIEW | ||
@@ -154,7 +154,7 @@ | ||
// absl::string_view is a typedef of std::string_view, use the feature macro | ||
// ABSL_USES_STD_STRING_VIEW. | ||
|
||
-#define ABSL_OPTION_USE_STD_STRING_VIEW 2 | ||
+#define ABSL_OPTION_USE_STD_STRING_VIEW @STD_STRING_VIEW@ | ||
|
||
// ABSL_OPTION_USE_STD_VARIANT | ||
// | ||
@@ -180,7 +180,7 @@ | ||
// absl::variant is a typedef of std::variant, use the feature macro | ||
// ABSL_USES_STD_VARIANT. | ||
|
||
-#define ABSL_OPTION_USE_STD_VARIANT 2 | ||
+#define ABSL_OPTION_USE_STD_VARIANT @STD_VARIANT@ | ||
|
||
|
||
// ABSL_OPTION_USE_INLINE_NAMESPACE |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
index 1911144..c749d28 100644 | ||
--- a/CMakeLists.txt | ||
+++ b/CMakeLists.txt | ||
@@ -257,6 +257,11 @@ include(cmake/re2.cmake) | ||
include(cmake/ssl.cmake) | ||
include(cmake/upb.cmake) | ||
include(cmake/zlib.cmake) | ||
+ | ||
+if (ABSL_USE_CXX17) | ||
+ message(STATUS "Found absl uses CXX17, enable CXX17 feature.") | ||
+ set(CMAKE_CXX_STANDARD 17) | ||
+endif() | ||
|
||
if(_gRPC_PLATFORM_MAC OR _gRPC_PLATFORM_IOS) | ||
set(_gRPC_ALLTARGETS_LIBRARIES ${CMAKE_DL_LIBS} m pthread) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support
--editable
mode.