[ignition-msgs*] Fix flaky CI tests for ignition-msgs* ports (take 2) #14730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass ADD_BIN_TO_PATH to vcpkg_install_cmake and remove custom PATH hacks.
traversaro
changed the title
strega-nil
approved these changes
Nov 23, 2020
JackBoosY
approved these changes
Nov 24, 2020
JackBoosY
added
category:port-bug
|
LGTM. |
|
Thanks @traversaro :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass
ADD_BIN_TO_PATHtovcpkg_install_cmakeand remove customPATHhacks. Less invasive version of #14464 thanks to @Neumann-A feedback.Describe the pull request
What does your PR fix? Fixes the problem mentioned in [ignition] Updates on various pkgs 🤖 #14324 (comment), not sure if there is a corresponding issue.
Which triplets are supported/not supported? Have you updated the CI baseline? The PR should not change the supported triplets.
Does your PR follow the maintainer guide? Yes
cc @BillyONeal