Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tiny-process-library] Bump tiny-process-library to 2.0.4 #14732

Merged
merged 3 commits into from Nov 30, 2020

Conversation

traversaro
Copy link
Contributor

Describe the pull request

  • What does your PR fix? This PR updates the tiny-process-library to the 2.0.3

  • Which triplets are supported/not supported? Have you updated the CI baseline? The baseline should not be affected.

  • Does your PR follow the maintainer guide? Yes

@PhoebeHui PhoebeHui added the category:port-update The issue is with a library, which is requesting update new revision label Nov 24, 2020
@PhoebeHui
Copy link
Contributor

@traversaro, thanks for the PR!

Here is CI testing results, could you please take a look?

x86-windows/x64-windows/arm64-windows/

LINK : fatal error LNK1104: cannot open file 'tiny-process-library.lib'

failure logs for x64-windows (1).zip

x64-windows-static/x64-linux

-- Configuring x64-windows-static
-- Building x64-windows-static-dbg
-- Building x64-windows-static-rel
CMake Error at scripts/cmake/vcpkg_fixup_cmake_targets.cmake:73 (message):
  'D:/packages/tiny-process-library_x64-windows-static/debug/lib/cmake/tiny-process-library'
  does not exist.
Call Stack (most recent call first):
  ports/tiny-process-library/portfile.cmake:21 (vcpkg_fixup_cmake_targets)
  scripts/ports.cmake:136 (include)

Error: Building package tiny-process-library:x64-windows-static failed with: BUILD_FAILED

@traversaro traversaro changed the title [tiny-process-library] Bump tiny-process-library to 2.0.3 [tiny-process-library] Bump tiny-process-library to 2.0.4 Nov 24, 2020
@traversaro
Copy link
Contributor Author

@traversaro, thanks for the PR!

Thanks for the comment @PhoebeHui ! I fixed all the problems, and now the port should work fine, I am not sure what happened to the CI jobs that staled.

)

vcpkg_configure_cmake(
SOURCE_PATH ${SOURCE_PATH}
PREFER_NINJA
OPTIONS
-DBUILD_TESTING=OFF
-DCMAKE_WINDOWS_EXPORT_ALL_SYMBOLS=ON
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the author of the library using it? if not, we should not add this in vcpkg. See https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/maintainer-guide.md#do-not-add-cmake_windows_export_all_symbols

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny-process-library is a small library with a few function and no templates, so CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS works as intended. It was already used in the patch that this PR removes. Furthermore, it was also added upstream in https://gitlab.com/eidheim/tiny-process-library/-/merge_requests/39, but it is set for an error after the add_library call, so it does not work as intended. Passing it for a command line is just a way to solve this problem before it is solved upstream (like a patch, but more future-proof).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@strega-nil, could you help confirm?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, LGTM

@traversaro
Copy link
Contributor Author

traversaro commented Nov 30, 2020

fyi @j-rivero, if you want to include tiny-process-library in the Gazebo vcpkg dependencies for compiling the Gazebo main command on Windows, after this PR the version that exports the correct CMake imported target is available in vpckg.

@traversaro
Copy link
Contributor Author

And thanks a lot @PhoebeHui and @strega-nil for reviewing and merging this!

@j-rivero
Copy link

j-rivero commented Dec 1, 2020

fyi @j-rivero, if you want to include tiny-process-library in the Gazebo vcpkg dependencies for compiling the Gazebo main command on Windows, after this PR the version that exports the correct CMake imported target is available in vpckg.

Thanks Silvio. Gazebo classic is not using dependencies from vcpkg in our CI, something I will need to fix or change at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants