Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libjpeg-turbo/mozjpeg] Add conflict messages #15196

Merged
merged 6 commits into from
Jan 11, 2021

Conversation

NancyLi1013
Copy link
Contributor

Describe the pull request

libjpeg-turbo and mozjpeg cannot be installed at the same time, since mozjpeg is based on libjpeg-turbo.

The references are as follows:
https://github.com/mozilla/mozjpeg/blob/master/README.md
https://github.com/mozilla/mozjpeg/blob/master/README-mozilla.txt

Note: No need to test features.

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Dec 18, 2020
@NancyLi1013
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Contributor Author

@BillyONeal
Could you please help take a look what's wrong on CI pipelines in this PR?
Thanks.

@BillyONeal
Copy link
Member

@NancyLi1013 It fails vcpkg's end to end tests:

Failed at [../src/vcpkg-test/manifests.cpp(635)] with message:
value was error

if I had to guess because you said Port-version rather than Port-Version in the CONTROL here.

ports/mozjpeg/CONTROL Outdated Show resolved Hide resolved
@NancyLi1013
Copy link
Contributor Author

Thanks for your help to pointing this out @BillyONeal.

Sorry, it's my mistake. Hope all checks pass this time.

@NancyLi1013
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jan 11, 2021
@JackBoosY
Copy link
Contributor

Maybe we should add a vcpkg_conflict_port function instead.

@vicroms vicroms merged commit 7fee6a4 into microsoft:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on installing tiff with mozjpeg
4 participants