[directxmath] port updated for cmake improvements #15383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
added
the
category:port-feature
PhoebeHui
added
category:port-bug
PhoebeHui
changed the title
I've not updated the version of the library. It's just fixed the CMake. |
PhoebeHui
requested changes
Dec 31, 2020
There was a problem hiding this comment.
@walbourn, I suggest to use the version that we referenced in portfile.cmake.
https://github.com/microsoft/DirectXMath/releases
PhoebeHui
approved these changes
Dec 31, 2020
PhoebeHui
added
info:reviewed
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR 15210 I added directxmath as a new port using the CMake integration upstream. This works fine on Windows and installs for x64-linux, but trying to use it from Linux with
find_packagefails.This is due to case-sensitivity in the Linux filesystem combined with a CamelCase
PROJECT_NAME, and the specific logic offind_packagebehavior (it needs<PackageName>Config.cmakeor<lowercase-packagename>-config.cmake). This is fixed upstream in this PR and this port updates to points to this version.Also moved the installed locations of DirectXMath headers into
include/DirectXMathto avoid any accidental include order issues since those headers are in the Windows SDK as well.