Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Restore x-upload-metrics command accidentally disabled by removing VCPKG_DISABLE_METRICS #15810

Merged
merged 2 commits into from
Jan 22, 2021
Merged

[vcpkg] Restore x-upload-metrics command accidentally disabled by removing VCPKG_DISABLE_METRICS #15810

merged 2 commits into from
Jan 22, 2021

Conversation

BillyONeal
Copy link
Member

… in #15470

I noticed this was messed up looking at the build log https://dev.azure.com/vcpkg/public/_build/results?buildId=48343&view=logs&j=0a61404f-5c45-5632-e83c-408b7fcca1d6&t=7cbd98da-c495-5b10-7ecd-f57aaa0a79d7 which has

commands.upload-metrics.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\a\1\s\build.x86.vs2017\vcpkglib.vcxproj]

@BillyONeal BillyONeal added category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:internal This PR or Issue was filed by the vcpkg team. labels Jan 22, 2021
@JackBoosY JackBoosY self-assigned this Jan 22, 2021
@BillyONeal BillyONeal merged commit 925b64e into microsoft:master Jan 22, 2021
@BillyONeal BillyONeal deleted the metrics_command branch January 22, 2021 19:10
@PhoebeHui PhoebeHui changed the title Restore x-upload-metrics command accidentally disabled by removing VCPKG_DISABLE_METRICS [vcpkg] Restore x-upload-metrics command accidentally disabled by removing VCPKG_DISABLE_METRICS Feb 2, 2021
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
@BillyONeal
Restore x-upload-metrics command accidentally disabled by removing VC…
52231c2 
…PKG_DISABLE_METRICS (microsoft#15810)

* Restore x-upload-metrics command accidentally disabled by removing VCPKG_DISABLE_METRICS in microsoft#15470

* Didn't save a file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219 ras0219 ras0219 approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BillyONeal @ras0219 @JackBoosY