New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[physfs] Patches to fix behavior on macOS / Linux #15962
Conversation
7dca406
to
64146e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you report this to the upstream?
Thanks.
@JackBoosY: |
I'm uneasy about adding these code changes without some guidance from upstream -- I'm not familiar enough with the specific semantics and codebase to properly review it. Assuming upstream gives the OK, then this LGTM |
Ping @past-due for response, does the upstream accept this changes? |
Haven't heard back - I will ping them again. |
@JackBoosY I'm pleased to note that upstream has now accepted these patches: icculus/physfs@a9cb207 (They also recently moved to GitHub, which made this a bit easier.) |
Describe the pull request
Adds two patches to fix behavior (and runtime failure handling) on macOS / Linux / other POSIX-compatible.
EINTR
(fixes runtime failures - more common on macOS Big Sur, and depending on system configuration and many other factors)O_CLOEXEC
/FD_CLOEXEC
(recommended behavior for libraries)All triplets should be supported.
I have reached out to upstream about these patches. Will update when there's a response.