Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[physfs] Patches to fix behavior on macOS / Linux #15962

Merged
merged 5 commits into from
Jul 23, 2021
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
73 changes: 73 additions & 0 deletions ports/physfs/002-fix-posix-eintr.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
diff --git a/src/physfs_platform_posix.c b/src/physfs_platform_posix.c
--- a/src/physfs_platform_posix.c
+++ b/src/physfs_platform_posix.c
@@ -6,8 +6,6 @@
* This file written by Ryan C. Gordon.
*/

-/* !!! FIXME: check for EINTR? */
-
#define __PHYSICSFS_INTERNAL__
#include "physfs_platforms.h"

@@ -167,7 +165,9 @@ static void *doOpen(const char *filename, int mode)
/* O_APPEND doesn't actually behave as we'd like. */
mode &= ~O_APPEND;

- fd = open(filename, mode, S_IRUSR | S_IWUSR);
+ do {
+ fd = open(filename, mode, S_IRUSR | S_IWUSR);
+ } while ((fd < 0) && (errno == EINTR));
BAIL_IF(fd < 0, errcodeFromErrno(), NULL);

if (appending)
@@ -219,7 +219,9 @@ PHYSFS_sint64 __PHYSFS_platformRead(void *opaque, void *buffer,
if (!__PHYSFS_ui64FitsAddressSpace(len))
BAIL(PHYSFS_ERR_INVALID_ARGUMENT, -1);

- rc = read(fd, buffer, (size_t) len);
+ do {
+ rc = read(fd, buffer, (size_t) len);
+ } while ((rc == -1) && (errno == EINTR));
BAIL_IF(rc == -1, errcodeFromErrno(), -1);
assert(rc >= 0);
assert(rc <= len);
@@ -236,7 +238,9 @@ PHYSFS_sint64 __PHYSFS_platformWrite(void *opaque, const void *buffer,
if (!__PHYSFS_ui64FitsAddressSpace(len))
BAIL(PHYSFS_ERR_INVALID_ARGUMENT, -1);

- rc = write(fd, (void *) buffer, (size_t) len);
+ do {
+ rc = write(fd, (void *) buffer, (size_t) len);
+ } while ((rc == -1) && (errno == EINTR));
BAIL_IF(rc == -1, errcodeFromErrno(), rc);
assert(rc >= 0);
assert(rc <= len);
@@ -275,8 +279,13 @@ PHYSFS_sint64 __PHYSFS_platformFileLength(void *opaque)
int __PHYSFS_platformFlush(void *opaque)
{
const int fd = *((int *) opaque);
- if ((fcntl(fd, F_GETFL) & O_ACCMODE) != O_RDONLY)
- BAIL_IF(fsync(fd) == -1, errcodeFromErrno(), 0);
+ int rc = -1;
+ if ((fcntl(fd, F_GETFL) & O_ACCMODE) != O_RDONLY) {
+ do {
+ rc = fsync(fd);
+ } while ((rc == -1) && (errno == EINTR));
+ BAIL_IF(rc == -1, errcodeFromErrno(), 0);
+ }
return 1;
} /* __PHYSFS_platformFlush */

@@ -284,7 +293,10 @@ int __PHYSFS_platformFlush(void *opaque)
void __PHYSFS_platformClose(void *opaque)
{
const int fd = *((int *) opaque);
- (void) close(fd); /* we don't check this. You should have used flush! */
+ int rc = -1;
+ do {
+ rc = close(fd); /* we don't check this. You should have used flush! */
+ } while ((rc == -1) && (errno == EINTR));
allocator.Free(opaque);
} /* __PHYSFS_platformClose */

34 changes: 34 additions & 0 deletions ports/physfs/003-fix-posix-cloexec.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
diff --git a/src/physfs_platform_posix.c b/src/physfs_platform_posix.c
--- a/src/physfs_platform_posix.c
+++ b/src/physfs_platform_posix.c
@@ -160,16 +160,30 @@ static void *doOpen(const char *filename, int mode)
const int appending = (mode & O_APPEND);
int fd;
int *retval;
+ int flags;
+ flags = -1;
errno = 0;

/* O_APPEND doesn't actually behave as we'd like. */
mode &= ~O_APPEND;
+
+#ifdef O_CLOEXEC
+ /* Add O_CLOEXEC if defined */
+ mode |= O_CLOEXEC;
+#endif

do {
fd = open(filename, mode, S_IRUSR | S_IWUSR);
} while ((fd < 0) && (errno == EINTR));
BAIL_IF(fd < 0, errcodeFromErrno(), NULL);

+#if !defined(O_CLOEXEC) && defined(FD_CLOEXEC)
+ flags = fcntl(fd, F_GETFD);
+ if (flags != -1) {
+ fcntl(fd, F_SETFD, flags | FD_CLOEXEC);
+ }
+#endif
+
if (appending)
{
if (lseek(fd, 0, SEEK_END) < 0)
4 changes: 3 additions & 1 deletion ports/physfs/portfile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ vcpkg_extract_source_archive_ex(
ARCHIVE ${ARCHIVE}
REF ${PHYSFS_VERSION}
PATCHES
"fix-lzmasdk-arm64-windows.patch"
"001-fix-lzmasdk-arm64-windows.patch"
"002-fix-posix-eintr.patch" # Remove this patch in the next update
"003-fix-posix-cloexec.patch" # Remove this patch in the next update
)

string(COMPARE EQUAL "${VCPKG_LIBRARY_LINKAGE}" "static" PHYSFS_STATIC)
Expand Down
2 changes: 1 addition & 1 deletion ports/physfs/vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "physfs",
"version-string": "3.0.2",
"port-version": 4,
"port-version": 5,
"description": "a library to provide abstract access to various archives",
"homepage": "https://icculus.org/physfs/",
"dependencies": [
Expand Down
2 changes: 1 addition & 1 deletion versions/baseline.json
Original file line number Diff line number Diff line change
Expand Up @@ -4514,7 +4514,7 @@
},
"physfs": {
"baseline": "3.0.2",
"port-version": 4
"port-version": 5
},
"physx": {
"baseline": "4.1.1",
Expand Down
5 changes: 5 additions & 0 deletions versions/p-/physfs.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "66d5438aabcfd4ec4a3e30e0f141fc8e6e5e99ce",
JackBoosY marked this conversation as resolved.
Show resolved Hide resolved
"version-string": "3.0.2",
"port-version": 5
},
{
"git-tree": "bef97b95b7c30545c4ec9d0a55f672c3a6e3325f",
"version-string": "3.0.2",
Expand Down