Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[(z_)vcpkg_prettify_command(_line)] Scripts Tree Audit #16130

Merged
merged 7 commits into from Feb 9, 2021
Merged

[(z_)vcpkg_prettify_command(_line)] Scripts Tree Audit #16130

merged 7 commits into from Feb 9, 2021

Conversation

strega-nil
Copy link
Contributor

Audit vcpkg_prettify_command to be in line with #16055

  • Since it's internal, rename to z_vcpkg_prettify_command_line
  • Change it from a macro to a function
  • Change how the function takes arguments, from taking two variable names, to taking a variable name output variable and the command line as the remaining arguments

Additionally, this adds the z_vcpkg_escape_argv helper macro from #16061, except that it's been renamed and modified slightly; #16061 should depend on this PR and use this new macro.

@strega-nil strega-nil mentioned this pull request Feb 8, 2021
Merged
@strega-nil strega-nil changed the title [vcpkg_prettify_command] Scripts Tree Audit [(z_)vcpkg_prettify_command(_line)] Scripts Tree Audit Feb 8, 2021
@JackBoosY JackBoosY added category:documentation To resolve the issue, documentation will need to be updated category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team. labels Feb 9, 2021
@strega-nil
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil strega-nil merged commit 545c165 into microsoft:master Feb 9, 2021
@strega-nil strega-nil deleted the scripts-audit/vcpkg_prettify_command branch February 11, 2021 21:54
@strega-nil strega-nil mentioned this pull request Feb 12, 2021
Open
@strega-nil strega-nil added the category:scripts-audit Part of the scripts audit effort. label Feb 12, 2021
@strega-nil strega-nil mentioned this pull request May 5, 2021
Closed
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neumann-A Neumann-A Neumann-A left review comments

@ras0219-msft ras0219-msft ras0219-msft approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:documentation To resolve the issue, documentation will need to be updated category:scripts-audit Part of the scripts audit effort. category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@strega-nil @ras0219-msft @Neumann-A @JackBoosY