New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] Add scripts tree extraction notes. #16055
Merged
BillyONeal
merged 11 commits into
microsoft:master
from
BillyONeal:scripts_extract_plans
Feb 18, 2021
Merged
[vcpkg] Add scripts tree extraction notes. #16055
BillyONeal
merged 11 commits into
microsoft:master
from
BillyONeal:scripts_extract_plans
Feb 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ras0219-msft
approved these changes
Feb 5, 2021
strega-nil
reviewed
Feb 5, 2021
strega-nil
reviewed
Feb 5, 2021
JackBoosY
added
category:documentation
To resolve the issue, documentation will need to be updated
category:vcpkg-feature
The issue is a new capability of the tool that doesn’t already exist and we haven’t committed
labels
Feb 7, 2021
PhoebeHui
changed the title
Add scripts tree extraction notes.
[vcpkg] Add scripts tree extraction notes.
Feb 7, 2021
strega-nil
added a commit
to strega-nil/vcpkg
that referenced
this pull request
Feb 10, 2021
See PR microsoft#16055 This also (attempts to) allow vcpkg.cmake to run with cmake 3.0; we had a VERSION_GREATER_EQUAL check, but that if keyword was added in cmake 3.7.
This was referenced Feb 12, 2021
also, remove the work list, to be replaced by issue microsoft#16188
# Conflicts: # scripts/cmake/execute_process.cmake
strega-nil
added a commit
that referenced
this pull request
Feb 19, 2021
* [vcpkg.cmake] modify to get in line with the audit See PR #16055 This also (attempts to) allow vcpkg.cmake to run with cmake 3.0; we had a VERSION_GREATER_EQUAL check, but that if keyword was added in cmake 3.7. * s/target_name/package_name in find_package * depend on z_vcpkg_function_arguments instead of a custom macro also, as a drive-by, switch to foreach(X IN LISTS ...) * split the utility macros/functions out additionally, move the options and settings to the top of the file * move more options and settings to the top * fix name of file * fix ras code comments * remove z_vcpkg_utilities due to export * add cmake_policy(PUSH|POP) * add VCPKG_INSTALLED_DIR input variable * add .cmakestamp to vcpkg_installed * fix osx ifs to use quotes also, remove spaces between if and (, to keep style consistent (mostly for ease of grepping...) * fix bug fixed by #16193 * move z_vcpkg_add_fatal_error up * fix RANGE for reals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:documentation
To resolve the issue, documentation will need to be updated
category:scripts-audit
Part of the scripts audit effort.
category:vcpkg-feature
The issue is a new capability of the tool that doesn’t already exist and we haven’t committed
info:internal
This PR or Issue was filed by the vcpkg team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.