Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] Add scripts tree extraction notes. #16055

Merged
merged 11 commits into from Feb 18, 2021

Conversation

BillyONeal
Copy link
Member

No description provided.

@JackBoosY JackBoosY added category:documentation To resolve the issue, documentation will need to be updated category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed labels Feb 7, 2021
@PhoebeHui PhoebeHui changed the title Add scripts tree extraction notes. [vcpkg] Add scripts tree extraction notes. Feb 7, 2021
@PhoebeHui PhoebeHui added the info:internal This PR or Issue was filed by the vcpkg team. label Feb 9, 2021
strega-nil added a commit to strega-nil/vcpkg that referenced this pull request Feb 10, 2021
See PR microsoft#16055

This also (attempts to) allow vcpkg.cmake to run with cmake 3.0; we had
a VERSION_GREATER_EQUAL check, but that if keyword was added in cmake
3.7.
also, remove the work list, to be replaced by issue microsoft#16188
# Conflicts:
#	scripts/cmake/execute_process.cmake
@BillyONeal BillyONeal merged commit 5dbf58d into microsoft:master Feb 18, 2021
@BillyONeal BillyONeal deleted the scripts_extract_plans branch February 18, 2021 22:10
strega-nil added a commit that referenced this pull request Feb 19, 2021
* [vcpkg.cmake] modify to get in line with the audit

See PR #16055

This also (attempts to) allow vcpkg.cmake to run with cmake 3.0; we had
a VERSION_GREATER_EQUAL check, but that if keyword was added in cmake
3.7.

* s/target_name/package_name in find_package

* depend on z_vcpkg_function_arguments

instead of a custom macro
also, as a drive-by, switch to foreach(X IN LISTS ...)

* split the utility macros/functions out

additionally, move the options and settings to the top of the file

* move more options and settings to the top

* fix name of file

* fix ras code comments

* remove z_vcpkg_utilities due to export
* add cmake_policy(PUSH|POP)
* add VCPKG_INSTALLED_DIR input variable
* add .cmakestamp to vcpkg_installed

* fix osx ifs to use quotes

also, remove spaces between if and (, to keep style consistent
(mostly for ease of grepping...)

* fix bug fixed by #16193

* move z_vcpkg_add_fatal_error up

* fix RANGE for reals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:documentation To resolve the issue, documentation will need to be updated category:scripts-audit Part of the scripts audit effort. category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants