Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python3] Add feature deprecated-win7-support. #16420

Merged
merged 6 commits into from
Mar 29, 2021

Conversation

Hoikas
Copy link
Contributor

@Hoikas Hoikas commented Feb 25, 2021

The PSF has a policy for dropping support for any Microsoft OS that is beyond end of support. As of Python 3.,9, Windows 7 support was dropped, preventing use the of the python3 port on any Windows 7 machine. The support drop was relatively soft, so this feature restores support for Windows 7 behind and off-by-default feature. The included patch forward-ports the fix for bpo-39401 from the Python 3.8 branch due to the Python 3.9 version requiring Windows 8. See python/cpython#18234 whose content is included in the 0007-restores-support-for-windows-7.patch, replacing the content of python/cpython#18231.

cc @ras0219-msft re discussion about this in discord last week.

This prevents potential patch application conflicts.
This backports the fix for bpo-39401 from the Python 3.8 branch instead
of the one from the Python 3.9 branch, which dropped support for Windows
7.
@Hoikas Hoikas marked this pull request as draft February 25, 2021 20:53
@Hoikas Hoikas marked this pull request as ready for review February 25, 2021 23:03
@Hoikas Hoikas changed the title [python3] Add feature deprecated-windows7-support. [python3] Add feature deprecated-win7-support. Feb 25, 2021
@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Feb 26, 2021
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted changes to the intermediate patch files which were otherwise unaffected -- other than that this LGTM.

@vicroms vicroms self-assigned this Mar 23, 2021
@vicroms vicroms merged commit aaa6a03 into microsoft:master Mar 29, 2021
@Hoikas Hoikas deleted the py3-win7 branch March 29, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants