Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[angle] Include EGL/eglext_angle.h in ANGLE #16733

Merged
merged 3 commits into from
Mar 19, 2021
Merged

[angle] Include EGL/eglext_angle.h in ANGLE #16733

merged 3 commits into from
Mar 19, 2021

Conversation

hanseuljun
Copy link
Contributor

Describe the pull request
Stops excluding eglext_angle.h from ANGLE. #14890

  • What does your PR fix? Fixes #
    eglext_angle.h includes entry points to angle-specific EGL extension functions and this PR exposes them.

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    I tested it on x64-windows and arm64-uwp.

  • Does your PR follow the maintainer guide?
    I think so. I updated the version of the port at least.

@NancyLi1013 NancyLi1013 self-assigned this Mar 17, 2021
@NancyLi1013 NancyLi1013 changed the title Include EGL/eglext_angle.h in ANGLE [angle] Include EGL/eglext_angle.h in ANGLE Mar 17, 2021
@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Mar 17, 2021
ports/angle/CONTROL Outdated Show resolved Hide resolved
@NancyLi1013
Copy link
Contributor

For the failure on x86-windows, please run vcpkg x-add-version angle and submit the changes to solve it.

Error: While reading versions for port angle from file: C:\a\1\s\versions\a-\angle.json
       Version `2020-05-15-2` was not found in versions file.
       Run:

           vcpkg x-add-version angle

       to add the new port version.

Note: Please update the changes first, then run the above command.

@hanseuljun
Copy link
Contributor Author

I ran vcpkg x-add-version angle but an error again... I guess it has to do with the previous version being 2020-05-15-1 not 2020-05-15...? Of course it's just a guess...

@NancyLi1013
Copy link
Contributor

Since you have updated versions, need to run vcpkg x-add-version --overwrite-version angle to overwrite the changes.

@hanseuljun
Copy link
Contributor Author

Ran x-add-version with the overwrite-version flag. Some new hash was assigned so it seems promising!

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Mar 18, 2021
@ras0219-msft ras0219-msft merged commit a125fe9 into microsoft:master Mar 19, 2021
@ras0219-msft
Copy link
Contributor

LGTM, thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants