-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenSSL] Update to 1.1.1k #16937
[OpenSSL] Update to 1.1.1k #16937
Conversation
Hi @metsma The failures on x86-windows like this:
|
OpenSSL is pure C and this is C++ class. Are you sure this error comes from OpenSSL |
The error is from
I tried to build this port on my machine and it can be built successfully. Comparing with the configure log, I found something different:
So the root cause seems that |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
The failures caused by |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
LGTM, thanks for your update @metsma. |
ping |
IMO This should be a priority over all other openssl port updates, considering the security content... |
Could you please resolve the conflicts in this PR? |
Signed-off-by: Raul Metsma <raul@metsma.ee>
Signed-off-by: Raul Metsma <raul@metsma.ee>
Conflict resolved |
Will the failed check block this PR? |
The failure seems to be fixed by #17492. |
This failure is not related with this PR, but we need to wait for the PR #17492 merged. I will rerun this PR once solved. |
It has been already month? How long takes to merge CVE fixes? |
Sorry for the long delay. Currently, we need to wait for PR #17492 merged. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Could you please help merge this PR? Thanks. |
Thanks @metsma, this is great :) |
Security fixes for CVE-2021-3450 and CVE-2021-3449
https://www.openssl.org/news/vulnerabilities.html
Use similar configure log file pattern as build log
Signed-off-by: Raul Metsma raul@metsma.ee
Fixed #17233