Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libdatachannel ] Update to 0.12.0 #17077

Merged
merged 7 commits into from
Apr 9, 2021
Merged

[libdatachannel ] Update to 0.12.0 #17077

merged 7 commits into from
Apr 9, 2021

Conversation

Nemirtingas
Copy link
Contributor

@Nemirtingas Nemirtingas commented Apr 4, 2021 •
edited
Loading

Describe the pull request
Update libdatachannel to 0.12.0, it requires libjuice 0.7.1 update before merging this.
#17076

@autoantwort
Copy link
Contributor

autoantwort commented Apr 4, 2021 •
edited
Loading

Use ./vcpkg format-manifest ports/libdatachannel/vcpkg.jsonto make the pipeline happy :)

And after that, run ./vcpkg x-add-version libdatachannel and commit the result

@Nemirtingas Nemirtingas closed this Apr 4, 2021
@Nemirtingas Nemirtingas reopened this Apr 4, 2021
@Nemirtingas
Copy link
Contributor Author

Use ./vcpkg format-manifest ports/libdatachannel/vcpkg.jsonto make the pipeline happy :)

And after that, run ./vcpkg x-add-version libdatachannel and commit the result

Ok thanks, wasn't aware of that new thing.

@JackBoosY JackBoosY added the category:port-update The issue is with a library, which is requesting update new revision label Apr 5, 2021
@NancyLi1013 NancyLi1013 changed the title Update libdatachannel to 0.12.0 [libdatachannel ] Update to 0.12.0 Apr 6, 2021
NancyLi1013
NancyLi1013 suggested changes Apr 6, 2021
View reviewed changes
ports/libdatachannel/vcpkg.json Outdated Show resolved Hide resolved
versions/l-/libdatachannel.json Outdated Show resolved Hide resolved
versions/baseline.json Outdated Show resolved Hide resolved
@NancyLi1013 NancyLi1013 added requires:author-response depends:different-pr This PR or Issue depends on a PR which has been filed labels Apr 6, 2021
@NancyLi1013
Copy link
Contributor

Hi @Nemirtingas

Thanks for your PR.
Have you tested these features in this PR?

@Nemirtingas Nemirtingas mentioned this pull request Apr 6, 2021
Merged
@Nemirtingas
Copy link
Contributor Author

Hi @Nemirtingas

Thanks for your PR.
Have you tested these features in this PR?

Hi, I tested the compilation with this feature, but I didn't test it runtime.

@NancyLi1013 NancyLi1013 removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Apr 8, 2021
NancyLi1013
NancyLi1013 suggested changes Apr 8, 2021
View reviewed changes
ports/libdatachannel/portfile.cmake Outdated Show resolved Hide resolved
Nemirtingas and others added 2 commits April 8, 2021 08:36
@Nemirtingas @NancyLi1013
Update ports/libdatachannel/portfile.cmake
6d51049 
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@GameDumper
Update version hash
e05e09c
@NancyLi1013
Copy link
Contributor

LGTM now, thanks for your update. @Nemirtingas

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Apr 8, 2021
@vicroms vicroms merged commit 9ec6217 into microsoft:master Apr 9, 2021
@Nemirtingas Nemirtingas deleted the libdatachannel_update branch April 9, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Nemirtingas @autoantwort @NancyLi1013 @vicroms @JackBoosY @GameDumper