Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libffi] Update patch to fix apply patch failure #17637

Merged
merged 2 commits into from
May 7, 2021
Merged

[libffi] Update patch to fix apply patch failure #17637

merged 2 commits into from
May 7, 2021

Conversation

JackBoosY
Copy link
Contributor

Fixes bug when using featrure versioning:

Starting package 1/2: libffi:x64-windows
Building package libffi[core]:x64-windows...
-- Installing port from location: F:\vcpkg\buildtrees\versioning\versions\libffi\ea2ed30397fc14caf66d8f7290306cfc5c5aa424
-- Using cached F:/vcpkg/downloads/libffi-libffi-v3.3.tar.gz
-- Extracting source F:/vcpkg/downloads/libffi-libffi-v3.3.tar.gz
-- Applying patch win64-disable-stackframe-check.patch
-- Applying patch win32-disable-stackframe-check.patch
CMake Error at scripts/cmake/z_vcpkg_apply_patches.cmake:57 (message):
  Applying patch failed: error: corrupt patch at line 27

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels May 3, 2021
@JackBoosY JackBoosY requested a review from NancyLi1013 May 7, 2021 01:58
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label May 7, 2021
@JackBoosY JackBoosY mentioned this pull request May 7, 2021
Open
@dan-shaw dan-shaw merged commit 86d689b into microsoft:master May 7, 2021
@JackBoosY JackBoosY deleted the dev/jack/update-libffi-patch branch May 8, 2021 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JackBoosY @NancyLi1013 @dan-shaw