Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aom] Add new port #18083

Merged
merged 9 commits into from
Jun 1, 2021
Merged

[aom] Add new port #18083

merged 9 commits into from
Jun 1, 2021

Conversation

HappySeaFox
Copy link
Contributor

@HappySeaFox HappySeaFox commented May 23, 2021 •
edited
Loading

Describe the pull request

Add AV1 codec library https://aomedia.googlesource.com/aom version 3.1.0.

  • What does your PR fix?

-

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Triplets: Everything except UWP and ARM.

CI baseline is not updated.

Yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes.

Port peculiarity:

  • Added missing CMake rules to install and export unofficial targets. Discussion is in [aom] Add new port #17332 .
  • AOM always builds an extra static lib when BUILD_SHARED_LIBS is ON which is not installed by the rules added above. We simply don't need it.

@HappySeaFox HappySeaFox marked this pull request as ready for review May 23, 2021 19:43
@HappySeaFox HappySeaFox marked this pull request as draft May 23, 2021 19:44
@HappySeaFox HappySeaFox marked this pull request as ready for review May 23, 2021 19:51
@NancyLi1013 NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label May 24, 2021
NancyLi1013
NancyLi1013 reviewed May 24, 2021
View reviewed changes
ports/aom/aom-install.diff Show resolved Hide resolved
ports/aom/vcpkg.json Outdated Show resolved Hide resolved
ras0219-msft
ras0219-msft approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

LGTM once my comment is answered :)

ports/aom/usage Outdated Show resolved Hide resolved
NancyLi1013
NancyLi1013 suggested changes May 25, 2021
View reviewed changes
ports/aom/portfile.cmake Outdated Show resolved Hide resolved
Dmitry Baryshev and others added 2 commits May 25, 2021 08:34
@NancyLi1013
[aom] Update ports/aom/portfile.cmake
d2d7688 
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
[aom] vcpkg x-add-version --all --overwrite-version
6c94d71
@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels May 25, 2021
@HappySeaFox
Copy link
Contributor Author

Ping!

@strega-nil-ms
Copy link
Contributor

Thanks @happy-sea-fox :)

@strega-nil-ms strega-nil-ms merged commit 835f161 into microsoft:master Jun 1, 2021
@NancyLi1013 NancyLi1013 mentioned this pull request Jun 2, 2021
Closed
@HappySeaFox HappySeaFox mentioned this pull request Jun 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft approved these changes

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HappySeaFox @strega-nil-ms @ras0219-msft @NancyLi1013