Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aom] Add new port #17332

Closed
wants to merge 4 commits into from
Closed

[aom] Add new port #17332

wants to merge 4 commits into from

Conversation

HappySeaFox
Copy link
Contributor

Describe the pull request

Add AV1 codec library

  • What does your PR fix?

-

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Triplets: Everything except UWP and ARM.

CI baseline is not updated.

Yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes.

@HappySeaFox HappySeaFox mentioned this pull request Apr 17, 2021
@NancyLi1013 NancyLi1013 changed the title Add AOM [aom ]Add new port Apr 19, 2021
@NancyLi1013 NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Apr 19, 2021
Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add dependency list if we use the suggested functions.

"dependencies": [
    {
      "name": "vcpkg-cmake",
      "host": true
    },
    {
      "name": "vcpkg-cmake-config",
      "host": true
    }
]

ports/aom/portfile.cmake Outdated Show resolved Hide resolved
ports/aom/portfile.cmake Outdated Show resolved Hide resolved
@HappySeaFox HappySeaFox changed the title [aom ]Add new port [aom] Add new port Apr 19, 2021
@HappySeaFox HappySeaFox marked this pull request as draft April 19, 2021 19:38
@HappySeaFox
Copy link
Contributor Author

@Hoikas It looks like upstream delayed and de-prioritized the task to add CMake installation rules. Can we add CMake installation rules in the port as I did earlier with a patch? If it's not recommended, then I'm afraid we can close this PR.

@Hoikas
Copy link
Contributor

Hoikas commented May 23, 2021

That sounds good to me, I just think the namespace needs to be changed to unofficial to match the rest of the targets added in vcpkg. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants