Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ms-quic] create a new port #18225

Merged
merged 7 commits into from Jul 25, 2021
Merged

[ms-quic] create a new port #18225

merged 7 commits into from Jul 25, 2021

Conversation

luncliff
Copy link
Contributor

@luncliff luncliff commented Jun 1, 2021 •
edited

What does your PR fix?

Afterwork of #17949 to support microsoft/msquic#1426

The package ms-quic:${triplet} provides CMake targets:

    find_package(msquic CONFIG REQUIRED)
    target_link_libraries(main PRIVATE msquic)

Which triplets are supported/not supported? Have you updated the CI baseline?

This port is dynamic only.

  • x86-windows
  • x64-windows
  • arm64-windows
  • x64-uwp
  • arm64-uwp
  • x64-linux
  • x64-osx
  • arm64-osx

Does your PR follow the maintainer guide?

Yes. I will keep my eye on it :D

@luncliff luncliff marked this pull request as draft June 1, 2021 16:31
@JonLiu1993 JonLiu1993 assigned JackBoosY and JonLiu1993 and unassigned JonLiu1993 Jun 2, 2021
@luncliff luncliff mentioned this pull request Jun 2, 2021
Closed
28 tasks
@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jun 2, 2021
@JackBoosY
Copy link
Contributor

Please ping me if you need any help.

@JackBoosY
Copy link
Contributor

Please get failure logs here.

@luncliff luncliff marked this pull request as ready for review July 10, 2021 15:19
JackBoosY
JackBoosY suggested changes Jul 12, 2021
View reviewed changes
ports/ms-quic/portfile.cmake Show resolved Hide resolved
ports/ms-quic/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jul 12, 2021
ras0219-msft
ras0219-msft reviewed Jul 15, 2021
View reviewed changes
ports/ms-quic/vcpkg.json Outdated Show resolved Hide resolved
ports/ms-quic/vcpkg.json Outdated Show resolved Hide resolved
ports/ms-quic/fix-warnings.patch Outdated Show resolved Hide resolved
ports/ms-quic/fix-cmakelists.patch Outdated Show resolved Hide resolved
@BillyONeal BillyONeal added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Jul 15, 2021
luncliff and others added 4 commits July 16, 2021 12:05
@luncliff @ras0219-msft
Update ports/ms-quic/vcpkg.json
3e21713 
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
@luncliff @ras0219-msft
Update ports/ms-quic/vcpkg.json
17de303 
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
@luncliff
[ms-quic] update patch files
eebb5f5
@luncliff
[ms-quic] make quictls only
2ecb24d 
* reduce feature list for future updates
* update version SHA
@luncliff
Copy link
Contributor Author

luncliff commented Jul 16, 2021 •
edited

I just found that MsQuic removed TLS option "stub" recently.
Seems like quictls/openssl is primary, so I made the port always use it instead of using default-features.

@JackBoosY JackBoosY added requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jul 16, 2021
@vicroms vicroms merged commit d30657b into microsoft:master Jul 25, 2021
@luncliff luncliff deleted the port/ms-quic branch July 26, 2021 00:43
@walbourn
Copy link
Member

The port here is still on 1.2, but the project is now on 2.1.8. Is there any reason not to update the port?

@dg0yt
Copy link
Contributor

dg0yt commented Apr 25, 2023

@walbourn you have to look at #29568.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

Assignees

@JackBoosY JackBoosY

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@luncliff @JackBoosY @walbourn @dg0yt @ras0219-msft @BillyONeal @vicroms @JonLiu1993