[portsmf] add new port with version 236 #18982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonLiu1993
added
the
category:new-port
JonLiu1993
requested changes
Jul 19, 2021
|
@Be-ing ，Could you modify the place suggested above |
|
I'm confused why this is acceptable but #18978 is not? |
Be-ing
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Generally speaking, if the user updates the port version, we encourage to update the latest cmake function, but if it is to add a new port, we will let the user directly use the latest cmake function |
|
That's not related to why #18978 was rejected. |
Sorry,for some major changes to the port, we must get official approval. |
JonLiu1993
approved these changes
Aug 2, 2021
Comment on lines
-3123
to
-3126
| "libebur128": { | ||
| "baseline": "1.2.6", | ||
| "port-version": 0 | ||
| }, |
There was a problem hiding this comment.
@Be-ing , Could you clarify why delete and re-add?
There was a problem hiding this comment.
I don't know. I did not make any manual changes to this. I only ran the vcpkg x-add-version tool.
JonLiu1993
approved these changes
Aug 3, 2021
JonLiu1993
added
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Adds new port for PortSMF
Which triplets are supported/not supported? Have you updated the CI baseline?
all except UWP
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?yes