Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[portmidi] update to 235.1; add macOS and Linux support #18978

Closed
wants to merge 1 commit into from

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Jul 16, 2021

PortMidi has been forked to https://github.com/mixxxdj/portmidi
and the build system rewritten with modern CMake so it works on
Windows, macOS, and Linux without requiring ugly hacks in the
portfile.cmake.

Describe the pull request

  • What does your PR fix?

    Fixes portmidi port not building on macOS and Linux

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all except UWP

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@Be-ing Be-ing force-pushed the portmidi_235.0 branch 2 times, most recently from 5248cf2 to afef734 Compare July 16, 2021 22:57
@Be-ing Be-ing changed the title [portmidi] update to 235.0; add macOS and Linux support [portmidi] update to 235.1; add macOS and Linux support Jul 16, 2021
@Be-ing Be-ing force-pushed the portmidi_235.0 branch 2 times, most recently from c19e66f to 5207d36 Compare July 17, 2021 13:29
PortMidi has been forked to https://github.com/mixxxdj/portmidi
and the build system rewritten with modern CMake so it works on
Windows, macOS, and Linux without requiring ugly hacks in the
portfile.cmake.
@NancyLi1013 NancyLi1013 added category:port-update The issue is with a library, which is requesting update new revision category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Jul 19, 2021
@NancyLi1013
Copy link
Contributor

Hi @Be-ing

Thanks for your PR. Seems the fork https://github.com/mixxxdj/portmidi is owned by you. Vcpkg only supports official repo. So could you please revert the repo from SourceForge?

@Be-ing
Copy link
Contributor Author

Be-ing commented Jul 19, 2021

The SourceForge project has been abandoned for years. The last update to SVN was 2018-07-23.

@NancyLi1013
Copy link
Contributor

The SourceForge project has been abandoned for years. The last update to SVN was 2018-07-23.

Thanks for your information. As I said above, vcpkg only supports official repo. The latest version 234 was updated 2020-08-04. And the maintainers are still working on this library. So we suggest to keep this repo.

@Be-ing
Copy link
Contributor Author

Be-ing commented Jul 20, 2021

Arch Linux and Alpine Linux packagers have expressed interest in updating their PortMidi packages with this fork. It's not the end of the world if you don't accept a fork of an unmaintained repository as legitimate because it's easy to keep this port in an overlay. However it would be inconvenient for other users if vcpkg fell behind and continued to not support macOS and Linux with this library whose whole purpose is to be cross platform. There may be new features added to this fork in the future and those surely won't be sent to SourceForge. I'm not going to learn to use SVN just to try to contribute to an unmaintained SourceForge project where it may very well be ignored indefinitely.

@NancyLi1013
Copy link
Contributor

@vicroms

Could you please help take a look if we can accept the new repo https://github.com/mixxxdj/portmidi? Thanks.

@Be-ing Be-ing marked this pull request as draft July 21, 2021 13:26
@Be-ing
Copy link
Contributor Author

Be-ing commented Jul 21, 2021

I need to do more testing with this...

@JackBoosY
Copy link
Contributor

Sorry but unless you are officially authorized to continue to maintain the port, we cannot accept this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants