[vcpkg_build_make] Always use msys make on win32 host #19164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
This PR ensures that
cmake_build_make
uses themake
program it acquires via msys, instead of allowing an instance of make which is earlier in the path, e.g. side by side with the compiler.Fixes issues like [libiconv:x64-mingw-dynamic] build failure #19117, hopefully (mingw32-make invoked as make with mingw32-w64 toolchain from Chocolatey.)
Which triplets are supported/not supported? Have you updated the CI baseline?
all (changing behaviour for windows hosts), no
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?not needed