Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Always use msys make on win32 host (#19164)" #19418

Closed
wants to merge 1 commit into from

Conversation

strega-nil
Copy link
Contributor

@strega-nil strega-nil commented Aug 6, 2021

Fixes issue #19417

@Neumann-A
Copy link
Contributor

probably because vcpkg_configure_make adds whatever MSYS_ROOT/usr/bin is used on the path and NO_DEFAULT_PATH breaks that.

@cenit
Copy link
Contributor

cenit commented Aug 6, 2021

isn't #19361 already working on that front and a better solution?

@strega-nil
Copy link
Contributor Author

strega-nil commented Aug 6, 2021

@cenit it may be, but this is an issue now (it's holding up CI whenever we rebuild), and a revert doesn't require the same amount of review.

@BillyONeal
Copy link
Member

I tested this locally in the same vcpkg instance as a repro of the build failure from last night and it passed.

@dg0yt
Copy link
Contributor

dg0yt commented Aug 6, 2021

Note that #19361 had good CI coverage, due to changing vcpkg_configure_make.

#19164 - as well as this revert - aren't equally well covered because they only change vcpkg_build_make, but some ports call only vcpkg_install_make. This is how the problem went unnoticed: Gettext and friends are not CI-tested, and now again!

@strega-nil-ms
Copy link
Contributor

Closing in favor of @dg0yt's PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants