[pistache] Delete the port.

[BillyONeal]

The port "pistache" was only installing its verdored copy of rapidjson, it wasn't actually installing anything related to itself. As a result, if rapidjson was already installed by vcpkg, and the port tried to use the one provided by vcpkg, nothing at all would be installed. There is no evidence that anyone actually used this port. The upstream project does not have proper cmake bindings set up, and it will require substantial modification of their build system to repair.

As a result, this change just deletes the port. It is likely that someone could add it back later in terms of meson, which seems to be the buildsystem preferred upstream.

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 1257354a3ab0bebd8abe95281ca561537853578c -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 0e38132..a5bfbc3 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4888,6 +4888,10 @@
       "baseline": "2019-07-11",
       "port-version": 0
     },
+    "pistache": {
+      "baseline": "2021-03-31",
+      "port-version": 1
+    },
     "pixel": {
       "baseline": "0.3-1",
       "port-version": 0

[PhoebeHui]

Could you please also remove it from https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt#L1217?

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 1257354a3ab0bebd8abe95281ca561537853578c -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 0e38132..a5bfbc3 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4888,6 +4888,10 @@
       "baseline": "2019-07-11",
       "port-version": 0
     },
+    "pistache": {
+      "baseline": "2021-03-31",
+      "port-version": 1
+    },
     "pixel": {
       "baseline": "0.3-1",
       "port-version": 0

[strega-nil-ms]

This is probably not the correct solution. We should instead roll back pistache, since pistache itself is not broken, the new version added was broken.

[strega-nil-ms]

Closing in favor of #19206

[BillyONeal]

This is probably not the correct solution. We should instead roll back pistache, since pistache itself is not broken, the new version added was broken.

It looks like it was always broken. But if you know how to fix it I agree that's better.

Closing in favor of #19206

Sounds great!