Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pistache] Delete the port. #19181

Closed
wants to merge 3 commits into from
Closed

[pistache] Delete the port. #19181

wants to merge 3 commits into from

Commits on Jul 28, 2021

  1. [pistache] Delete the port. 

    The port "pistache" was only installing its verdored copy of rapidjson, it wasn't actually installing anything related to itself. As a result, if rapidjson was already installed by vcpkg, and the port tried to use the one provided by vcpkg, nothing at all would be installed. There is no evidence that anyone actually used this port. The upstream project does not have proper cmake bindings set up, and it will require substantial modification of their build system to repair.

As a result, this change just deletes the port. It is likely that someone could add it back later in terms of meson, which seems to be the buildsystem preferred upstream.
    @BillyONeal
    BillyONeal committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    faf9a08 View commit details
    Browse the repository at this point in the history

  2. Delete baseline.json entry.

    @BillyONeal
    BillyONeal committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    7b67315 View commit details
    Browse the repository at this point in the history

  3. remove pistache from ci.baseline.txt

    @strega-nil
    strega-nil committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    3334eda View commit details
    Browse the repository at this point in the history