Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libdatachannel][libjuice] Update libdatachannel to 0.14.1 and libjuice to 0.8.4. #19305

Merged
merged 9 commits into from
Aug 5, 2021

Conversation

Nemirtingas
Copy link
Contributor

Describe the pull request

What does your PR fix?

Nothing, updates libraries.

Which triplets are supported/not supported? Have you updated the CI baseline?

Same triplets as before are supported, I personally tested Windows and Linux triplets.

Does your PR follow the maintainer guide?

Yes.

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes.

New PR to continue #19268 because I removed my remote branch...

@Nemirtingas Nemirtingas changed the title Libdatachannel update [libdatachannel][libjuice] Update libdatachannel to 0.14.0 and libjuice to 0.8.2. Aug 2, 2021
@Nemirtingas Nemirtingas changed the title [libdatachannel][libjuice] Update libdatachannel to 0.14.0 and libjuice to 0.8.2. [libdatachannel][libjuice] Update libdatachannel to 0.14.0 and libjuice to 0.8.4. Aug 2, 2021
@Nemirtingas
Copy link
Contributor Author

Nemirtingas commented Aug 2, 2021

Need to investigate on uwp compilation.
paullouisageneau/libdatachannel#388 (comment)

libdatachannel:x64-uwp and libdatachannel:arm-uwp failed with following failures in CI testing, could you please take a look?

   4>D:\buildtrees\libdatachannel\src\v0.14.0-ded584d6a1.clean\src\impl\certificate.cpp(205,31): error C3861: 'PEM_read_X509': identifier not found [D:\buildtrees\libdatachannel\x64-uwp-dbg\datachannel.vcxproj]
     4>D:\buildtrees\libdatachannel\src\v0.14.0-ded584d6a1.clean\src\impl\certificate.cpp(207,11): error C3536: 'x509': cannot be used before it is initialized [D:\buildtrees\libdatachannel\x64-uwp-dbg\datachannel.vcxproj]
     4>D:\buildtrees\libdatachannel\src\v0.14.0-ded584d6a1.clean\src\impl\certificate.cpp(215,6): error C3861: 'PEM_read_PrivateKey': identifier not found [D:\buildtrees\libdatachannel\x64-uwp-dbg\datachannel.vcxproj]
     4>D:\buildtrees\libdatachannel\src\v0.14.0-ded584d6a1.clean\src\impl\certificate.cpp(218,11): error C3536: 'pkey': cannot be used before it is initialized [D:\buildtrees\libdatachannel\x64-uwp-dbg\datachannel.vcxproj]
     4>D:\buildtrees\libdatachannel\src\v0.14.0-ded584d6a1.clean\src\impl\certificate.cpp(221,31): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'rtc::impl::Certificate' [D:\buildtrees\libdatachannel\x64-uwp-dbg\datachannel.vcxproj]

@Nemirtingas Nemirtingas changed the title [libdatachannel][libjuice] Update libdatachannel to 0.14.0 and libjuice to 0.8.4. [libdatachannel][libjuice] Update libdatachannel to 0.14.1 and libjuice to 0.8.4. Aug 2, 2021
@JonLiu1993 JonLiu1993 self-assigned this Aug 3, 2021
@JonLiu1993 JonLiu1993 added category:port-update The issue is with a library, which is requesting update new revision requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Aug 3, 2021
@JonLiu1993
Copy link
Member

@Nemirtingas ,I tested the feature nettle of libjuice in x86-windows triplet,but it failed,could you take a look:

LINK Pass 1: command "C:\PROGRA~2\MICROS~1\2019\ENTERP~1\VC\Tools\MSVC\1429~1.300\bin\Hostx64\x86\link.exe CMakeFiles\juice.dir\src\addr.c.obj CMakeFiles\juice.dir\src\agent.c.obj CMakeFiles\juice.dir\src\crc32.c.obj CMakeFiles\juice.dir\src\const_time.c.obj CMakeFiles\juice.dir\src\base64.c.obj CMakeFiles\juice.dir\src\hash.c.obj CMakeFiles\juice.dir\src\hmac.c.obj CMakeFiles\juice.dir\src\ice.c.obj CMakeFiles\juice.dir\src\juice.c.obj CMakeFiles\juice.dir\src\log.c.obj CMakeFiles\juice.dir\src\random.c.obj CMakeFiles\juice.dir\src\server.c.obj CMakeFiles\juice.dir\src\stun.c.obj CMakeFiles\juice.dir\src\timestamp.c.obj CMakeFiles\juice.dir\src\turn.c.obj CMakeFiles\juice.dir\src\udp.c.obj /out:juice.dll /implib:juice.lib /pdb:juice.pdb /dll /version:0.8 /machine:X86 /nologo /debug /INCREMENTAL ws2_32.lib bcrypt.lib nettle.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:CMakeFiles\juice.dir/intermediate.manifest CMakeFiles\juice.dir/manifest.res" failed (exit code 1104) with the following output:
LINK : fatal error LNK1104: cannot open file 'nettle.lib'

@Nemirtingas
Copy link
Contributor Author

Nemirtingas commented Aug 3, 2021

I fixed it locally, but I have another issue when building libdatachannel, without specifying the library status, cmake should build a static or shared library depending on BUILD_SHARED_LIBS. In my case, BUILD_SHARED_LIBS is set to ON but libdatachannel is built statically nonetheless.

Nvm, I found it.

@Nemirtingas
Copy link
Contributor Author

Everything should be ok now.

@JonLiu1993
Copy link
Member

For port libdatachannel and libjuice all features are tested successfully in the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-static

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Aug 4, 2021
@Nemirtingas
Copy link
Contributor Author

Nemirtingas commented Aug 4, 2021

For port libdatachannel and libjuice all features are tested successfully in the following triplet:

* x86-windows

* x64-windows

* x64-windows-static

I just tested

  • x86-linux
  • x64-linux
  • x86-linux-dynamic
  • x64-linux-dynamic
    It compiles just fine.

@dan-shaw dan-shaw merged commit f2e53ad into microsoft:master Aug 5, 2021
@Nemirtingas Nemirtingas deleted the libdatachannel_update branch October 11, 2021 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants