-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libdatachannel][libjuice] Update libdatachannel to 0.14.1 and libjuice to 0.8.4. #19305
Conversation
Need to investigate on uwp compilation.
|
Fixes *-uwp.
@Nemirtingas ,I tested the feature nettle of libjuice in x86-windows triplet,but it failed,could you take a look:
|
I fixed it locally, but I have another issue when building libdatachannel, without specifying the library status, cmake should build a static or shared library depending on BUILD_SHARED_LIBS. In my case, BUILD_SHARED_LIBS is set to ON but libdatachannel is built statically nonetheless. Nvm, I found it. |
Everything should be ok now. |
For port libdatachannel and libjuice all features are tested successfully in the following triplet:
|
I just tested
|
Describe the pull request
Nothing, updates libraries.
Same triplets as before are supported, I personally tested Windows and Linux triplets.
Yes.
Yes.
New PR to continue #19268 because I removed my remote branch...