Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECM] fix FindCanberra for static builds #20213

Merged
merged 4 commits into from
Sep 17, 2021

Conversation

wrobelda
Copy link
Contributor

@wrobelda wrobelda commented Sep 16, 2021

Also remove dangling do-not-override-custom-clang-format-files.patch

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/ecm/portfile.cmake

@wrobelda wrobelda mentioned this pull request Sep 16, 2021
4 tasks
@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Sep 17, 2021
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Sep 17, 2021
@BillyONeal BillyONeal merged commit 57ab68d into microsoft:master Sep 17, 2021
@BillyONeal
Copy link
Member

Thanks for the fix!

@wrobelda wrobelda deleted the ecm_canberra_fix branch September 17, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants