[kf5notifications] new port #19828

wrobelda · 2021-08-31T16:18:41Z

Describe the pull request
Adds new port.
Depends on:

[kf5coreaddons] fix Windows static builds & CMake Config #19439
[libcanberra] new port #19816
[ECM] fix FindCanberra for static builds #20213
[libsnoretoast] fix absolute include paths #20229
Which triplets are supported/not supported? Have you updated the CI baseline?

All official, plus arm64-osx
Does your PR follow the maintainer guide?

Yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

hellozee · 2021-08-31T19:08:21Z

This only fails in the CI, locally works. For some reason it looks into the wrong directory I suppose or it just be the CI is configured that way. Cause it refers to the location where snoretoast is installed before running the post install checks.

wrobelda · 2021-08-31T20:58:15Z

This only fails in the CI, locally works. For some reason it looks into the wrong directory I suppose or it just be the CI is configured that way. Cause it refers to the location where snoretoast is installed before running the post install checks.

Same exact experience.

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/ecm/portfile.cmake
ports/kf5notifications/portfile.cmake
ports/libcanberra/portfile.cmake

NancyLi1013 · 2021-09-17T03:15:10Z

The failures are like this:

Installing in D:/packages/kf5notifications_x86-windows/debug. Run D:/buildtrees/kf5notifications/x86-windows-dbg/prefix.sh to set the environment for KNotifications.
CMake Error in src/CMakeLists.txt:
  Imported target "SnoreToast::SnoreToastActions" includes non-existent path

    "D:/packages/libsnoretoast_x86-windows/include/snoretoast"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.



CMake Error in src/CMakeLists.txt:
  Imported target "SnoreToast::SnoreToastActions" includes non-existent path

    "D:/packages/libsnoretoast_x86-windows/include/snoretoast"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

hellozee · 2021-09-17T04:16:47Z

It is not reproducible locally tbh, no idea if we are doing anything wrong or there is something wrong with the CI.

dg0yt · 2021-09-17T05:51:20Z

CMake Error in src/CMakeLists.txt:
Imported target "SnoreToast::SnoreToastActions" includes non-existent path
"D:/packages/libsnoretoast_x86-windows/include/snoretoast"
in its INTERFACE_INCLUDE_DIRECTORIES.

and

It is not reproducible locally tbh, no idea if we are doing anything wrong or there is something wrong with the CI.

It is a packages path. You may have this path locally after building the dependency libsnoretoast. But it may be missing after removal & re-install from cache.
Please check the exported config from libsnoretoast for references to packages.

hellozee · 2021-09-17T06:43:14Z

Ahh make sense, would check that.

wrobelda · 2021-09-17T11:50:34Z

It is a packages path. You may have this path locally after building the dependency libsnoretoast. But it may be missing after removal & re-install from cache.
Please check the exported config from libsnoretoast for references to packages.

This is more nuanced than that. Locally built Config.cmake has:

  INTERFACE_INCLUDE_DIRECTORIES "C:/vcpkg/packages/libsnoretoast_x64-windows-static/include/snoretoast"

The path is correct, and the headers are included in the cached package:

PS C:\vcpkg> cat .\installed\vcpkg\info\libsnoretoast_0.8.0_x64-windows-static.list
x64-windows-static/
x64-windows-static/include/
x64-windows-static/include/snoretoast/
x64-windows-static/include/snoretoast/config.h
x64-windows-static/include/snoretoast/snoretoastactions.h
x64-windows-static/share/
x64-windows-static/share/libsnoretoast/
x64-windows-static/share/libsnoretoast/LibSnoreToastConfig-debug.cmake
x64-windows-static/share/libsnoretoast/LibSnoreToastConfig-release.cmake
x64-windows-static/share/libsnoretoast/LibSnoreToastConfig.cmake
x64-windows-static/share/libsnoretoast/copyright
x64-windows-static/share/libsnoretoast/vcpkg_abi_info.txt
x64-windows-static/tools/
x64-windows-static/tools/libsnoretoast/
x64-windows-static/tools/libsnoretoast/snoretoast.exe

EDIT: scratch that, just realized we're talking about the ephemeral packages folder, not the installed 🤦🏻‍♂️
EDIT2: Hardcoded CMAKE_INSTALL_PREFIX usage caused this: https://github.com/KDE/snoretoast/blob/2fae686f5826ac4c407c772db56873f538a384ba/src/CMakeLists.txt#L2
EDIT3: #20229 fixes it

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for libsnoretoast but no changes to version or port version.
-- Version: 0.8.0
-- Old SHA: 7ddd1b84089de293b4a9d74af6b7593d089084a9
-- New SHA: c30fe7a20b36f824198b72117cb13ae5e4eec46b
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 30a3d841d88dbf1e668d875bcfc050aacdedc63b -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/l-/libsnoretoast.json b/versions/l-/libsnoretoast.json
index 713dbcb..609c6e7 100644
--- a/versions/l-/libsnoretoast.json
+++ b/versions/l-/libsnoretoast.json
@@ -1,8 +1,8 @@
 {
   "versions": [
     {
-      "git-tree": "c30fe7a20b36f824198b72117cb13ae5e4eec46b",
-      "version": "0.8.0",
+      "git-tree": "7ddd1b84089de293b4a9d74af6b7593d089084a9",
+      "version-semver": "0.8.0",
       "port-version": 0
     }
   ]

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/ecm/portfile.cmake
ports/ffnvcodec/portfile.cmake
ports/kf5notifications/portfile.cmake
ports/libcanberra/portfile.cmake
ports/libproxy/portfile.cmake
ports/libsnoretoast/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for libsnoretoast but no changes to version or port version.
-- Version: 0.8.0
-- Old SHA: 7ddd1b84089de293b4a9d74af6b7593d089084a9
-- New SHA: babb3a1599adf46a6862815fab452d9048920c84
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 69d5556d0d8c105f75055326cef346546e40e615 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/l-/libsnoretoast.json b/versions/l-/libsnoretoast.json
index 6c478ba..609c6e7 100644
--- a/versions/l-/libsnoretoast.json
+++ b/versions/l-/libsnoretoast.json
@@ -1,8 +1,8 @@
 {
   "versions": [
     {
-      "git-tree": "babb3a1599adf46a6862815fab452d9048920c84",
-      "version": "0.8.0",
+      "git-tree": "7ddd1b84089de293b4a9d74af6b7593d089084a9",
+      "version-semver": "0.8.0",
       "port-version": 0
     }
   ]

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/ecm/portfile.cmake
ports/ffnvcodec/portfile.cmake
ports/kf5notifications/portfile.cmake
ports/libcanberra/portfile.cmake
ports/libproxy/portfile.cmake
ports/libsnoretoast/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 69d5556d0d8c105f75055326cef346546e40e615 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/l-/libsnoretoast.json b/versions/l-/libsnoretoast.json
index 53233ef..513047f 100644
--- a/versions/l-/libsnoretoast.json
+++ b/versions/l-/libsnoretoast.json
@@ -6,8 +6,8 @@
       "port-version": 1
     },
     {
-      "git-tree": "babb3a1599adf46a6862815fab452d9048920c84",
-      "version": "0.8.0",
+      "git-tree": "7ddd1b84089de293b4a9d74af6b7593d089084a9",
+      "version-semver": "0.8.0",
       "port-version": 0
     }
   ]

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/ecm/portfile.cmake
ports/ffnvcodec/portfile.cmake
ports/kf5notifications/portfile.cmake
ports/libcanberra/portfile.cmake
ports/libproxy/portfile.cmake
ports/libsnoretoast/portfile.cmake

wrobelda · 2021-09-28T00:57:27Z

@NancyLi1013 this no longer has any dependencies, ready to be merged.

ports/kf5notifications/fix_config_cmake.patch

ports/kf5notifications/vcpkg.json

NancyLi1013 · 2021-09-28T09:52:17Z

/azp run

azure-pipelines · 2021-09-28T09:52:26Z

Azure Pipelines successfully started running 1 pipeline(s).

BillyONeal · 2021-09-29T15:32:25Z

Thanks for all the kf5Xxx ports!

github-actions bot approved these changes Aug 31, 2021

View reviewed changes

wrobelda force-pushed the knotifications_canberra branch from 03c1ba5 to 7dd7489 Compare August 31, 2021 18:36

github-actions bot approved these changes Aug 31, 2021

View reviewed changes

JonLiu1993 assigned NancyLi1013 Sep 1, 2021

NancyLi1013 added category:new-port The issue is requesting a new library to be added; consider making a PR! depends:different-pr This PR or Issue depends on a PR which has been filed labels Sep 1, 2021

wrobelda force-pushed the knotifications_canberra branch from 7dd7489 to 7527235 Compare September 1, 2021 09:43

github-actions bot approved these changes Sep 1, 2021

View reviewed changes

This was referenced Sep 16, 2021

[kf5declarative] new port #19813

Merged

[ECM] fix FindCanberra for static builds #20213

Merged

wrobelda force-pushed the knotifications_canberra branch from 7527235 to 1d23f3c Compare September 16, 2021 22:32

github-actions bot approved these changes Sep 16, 2021

View reviewed changes

wrobelda marked this pull request as ready for review September 16, 2021 22:36

github-actions bot requested changes Sep 17, 2021

View reviewed changes

wrobelda force-pushed the knotifications_canberra branch from 972f817 to 72e874b Compare September 17, 2021 12:39

github-actions bot requested changes Sep 17, 2021

View reviewed changes

wrobelda force-pushed the knotifications_canberra branch from 72e874b to 81e8334 Compare September 17, 2021 12:42

github-actions bot requested changes Sep 17, 2021

View reviewed changes

wrobelda mentioned this pull request Sep 17, 2021

[libsnoretoast] fix absolute include paths #20229

Merged

wrobelda added 11 commits September 28, 2021 03:56

[kf5notifications] update to 5.84.0

16fd76f

[kf5notifications] update versions

be0e7ec

[kf5notifications] remove bin from static builds

49f15fe

[kf5notifications] update versions

416c90f

[kf5notifications] add kf5windowsystem dependency

90097a3

[kf5notifications] update versions

1b9efa1

[kf5notifications] fix CMake config file

ec53b50

[kf5notifications] update versions

31c65ef

[kf5notifications] add androidextras dependency

52e3a42

[kf5notifications] update versions

903094f

[kf5notifications] update versions

ab7feaa

wrobelda force-pushed the knotifications_canberra branch from 0ef66c6 to ab7feaa Compare September 28, 2021 00:56

github-actions bot approved these changes Sep 28, 2021

View reviewed changes

NancyLi1013 removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Sep 28, 2021

NancyLi1013 suggested changes Sep 28, 2021

View reviewed changes

ports/kf5notifications/fix_config_cmake.patch Outdated Show resolved Hide resolved

ports/kf5notifications/vcpkg.json Outdated Show resolved Hide resolved

wrobelda added 3 commits September 28, 2021 04:13

[kf5newstuff] minimize patch size

b507a85

[kf5newstuff] use generic, non-semver versioning

666f681

[kf5newstuff] update versions

5ae6e4d

github-actions bot approved these changes Sep 28, 2021

View reviewed changes

wrobelda added 2 commits September 28, 2021 04:15

[kf5notifications] re-enable parallel configure

a6c0a19

[kf5notifications] update versions

412fc06

github-actions bot approved these changes Sep 28, 2021

View reviewed changes

wrobelda mentioned this pull request Sep 28, 2021

[kf5kio] new port #19779

Merged

5 tasks

NancyLi1013 approved these changes Sep 28, 2021

View reviewed changes

NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Sep 29, 2021

BillyONeal merged commit a7e7bcd into microsoft:master Sep 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[kf5notifications] new port #19828

[kf5notifications] new port #19828

wrobelda commented Aug 31, 2021 •

edited

Loading

hellozee commented Aug 31, 2021

wrobelda commented Aug 31, 2021

github-actions bot left a comment

NancyLi1013 commented Sep 17, 2021

hellozee commented Sep 17, 2021

dg0yt commented Sep 17, 2021 •

edited

Loading

hellozee commented Sep 17, 2021

wrobelda commented Sep 17, 2021 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

wrobelda commented Sep 28, 2021

NancyLi1013 commented Sep 28, 2021

azure-pipelines bot commented Sep 28, 2021

BillyONeal commented Sep 29, 2021

[kf5notifications] new port #19828

[kf5notifications] new port #19828

Conversation

wrobelda commented Aug 31, 2021 • edited Loading

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

hellozee commented Aug 31, 2021

wrobelda commented Aug 31, 2021

github-actions bot left a comment

Choose a reason for hiding this comment

NancyLi1013 commented Sep 17, 2021

hellozee commented Sep 17, 2021

dg0yt commented Sep 17, 2021 • edited Loading

hellozee commented Sep 17, 2021

wrobelda commented Sep 17, 2021 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

wrobelda commented Sep 28, 2021

NancyLi1013 commented Sep 28, 2021

azure-pipelines bot commented Sep 28, 2021

BillyONeal commented Sep 29, 2021

wrobelda commented Aug 31, 2021 •

edited

Loading

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

dg0yt commented Sep 17, 2021 •

edited

Loading

wrobelda commented Sep 17, 2021 •

edited

Loading