Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libsnoretoast] fix absolute include paths #20229

Merged
merged 5 commits into from
Sep 20, 2021

Conversation

wrobelda
Copy link
Contributor

@wrobelda wrobelda commented Sep 17, 2021

Describe the pull request
Fixes issues with LibSnoreToast usage on Windows. See: #19828 (comment)

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    No change.

  • Does your PR follow the maintainer guide?

    Yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for libsnoretoast but no changes to version or port version.
-- Version: 0.8.0
-- Old SHA: 7ddd1b84089de293b4a9d74af6b7593d089084a9
-- New SHA: c30fe7a20b36f824198b72117cb13ae5e4eec46b
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 69d5556d0d8c105f75055326cef346546e40e615 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/l-/libsnoretoast.json b/versions/l-/libsnoretoast.json
index 713dbcb..609c6e7 100644
--- a/versions/l-/libsnoretoast.json
+++ b/versions/l-/libsnoretoast.json
@@ -1,8 +1,8 @@
 {
   "versions": [
     {
-      "git-tree": "c30fe7a20b36f824198b72117cb13ae5e4eec46b",
-      "version": "0.8.0",
+      "git-tree": "7ddd1b84089de293b4a9d74af6b7593d089084a9",
+      "version-semver": "0.8.0",
       "port-version": 0
     }
   ]

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/ffnvcodec/portfile.cmake
  • ports/libproxy/portfile.cmake
  • ports/libsnoretoast/portfile.cmake

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for libsnoretoast but no changes to version or port version.
-- Version: 0.8.0
-- Old SHA: 7ddd1b84089de293b4a9d74af6b7593d089084a9
-- New SHA: babb3a1599adf46a6862815fab452d9048920c84
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 69d5556d0d8c105f75055326cef346546e40e615 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/l-/libsnoretoast.json b/versions/l-/libsnoretoast.json
index 6c478ba..609c6e7 100644
--- a/versions/l-/libsnoretoast.json
+++ b/versions/l-/libsnoretoast.json
@@ -1,8 +1,8 @@
 {
   "versions": [
     {
-      "git-tree": "babb3a1599adf46a6862815fab452d9048920c84",
-      "version": "0.8.0",
+      "git-tree": "7ddd1b84089de293b4a9d74af6b7593d089084a9",
+      "version-semver": "0.8.0",
       "port-version": 0
     }
   ]

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/ffnvcodec/portfile.cmake
  • ports/libproxy/portfile.cmake
  • ports/libsnoretoast/portfile.cmake

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 69d5556d0d8c105f75055326cef346546e40e615 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/l-/libsnoretoast.json b/versions/l-/libsnoretoast.json
index 53233ef..513047f 100644
--- a/versions/l-/libsnoretoast.json
+++ b/versions/l-/libsnoretoast.json
@@ -6,8 +6,8 @@
       "port-version": 1
     },
     {
-      "git-tree": "babb3a1599adf46a6862815fab452d9048920c84",
-      "version": "0.8.0",
+      "git-tree": "7ddd1b84089de293b4a9d74af6b7593d089084a9",
+      "version-semver": "0.8.0",
       "port-version": 0
     }
   ]

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/ffnvcodec/portfile.cmake
  • ports/libproxy/portfile.cmake
  • ports/libsnoretoast/portfile.cmake

@NancyLi1013 NancyLi1013 added the category:port-bug The issue is with a library, which is something the port should already support label Sep 18, 2021
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Sep 18, 2021
@NancyLi1013
Copy link
Contributor

LGTM, thanks for your fixing.

@BillyONeal
Copy link
Member

The version database for previous versions was damaged so I fixed it to only add the new port-version.

@BillyONeal BillyONeal merged commit 36fe652 into microsoft:master Sep 20, 2021
@BillyONeal
Copy link
Member

Thanks for the fix :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants