[OpenMVS] restore deprecated cmake scripts for configure, build & fixup targets

[cenit]

During boost 1.77 upgrade, openmvs was updated to new vcpkg-cmake port for configure, build & fixup.
Unfortunately, it does not work correctly and consuming the library since then is broken.

Inside OpenMVSTargets.cmake the fixup deprecated script works correctly and produces this line

set(_IMPORT_PREFIX "${CMAKE_CURRENT_LIST_DIR}/../..")

while the new one produces this broken line

set(_IMPORT_PREFIX "${_IMPORT_PREFIX}")

We should fix the fixup script, but since i am not such an expert in dealing with regex-es, i suggest for now to revert the upgrade to a working script, while we try to understand what went wrong there (usually the new one works, but not with this port)

@strega-nil @strega-nil-ms

[github-actions]

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

• ports/openmvs/portfile.cmake

[strega-nil-ms]

Can you just switch back to vcpkg_fixup_cmake_targets? There's no reason to switch back to vcpkg_*_cmake aiui.

[cenit]

cmake errors due to including vcpkg-cmake port and using old fixup script

[cenit]

any news? openmvs is broken on master since 28th Sep...

[strega-nil-ms]

@cenit vcpkg_fixup_cmake_targets doesn't check for vcpkg-cmake; it only checks for vcpkg-cmake-config. I'm going to try pushing the other change. If it fails, I'll merge the original change.

[github-actions]

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

• ports/openmvs/portfile.cmake

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout e1c8bbd3c6731cd988eb7e27d2fd0de7983e454d -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/o-/openmvs.json b/versions/o-/openmvs.json
index 50afb3e..8ce9dd4 100644
--- a/versions/o-/openmvs.json
+++ b/versions/o-/openmvs.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "4567d6956e82463039bc521d479144cff5db305f",
+      "git-tree": "168233263a9b959a9a19f1eb2d6f462d5257d18f",
       "version": "1.1.1",
       "port-version": 1
     },

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

• ports/openmvs/portfile.cmake

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/openmvs/vcpkg.json b/ports/openmvs/vcpkg.json
index d587ebe..fa03e4d 100644
--- a/ports/openmvs/vcpkg.json
+++ b/ports/openmvs/vcpkg.json
@@ -14,10 +14,6 @@
       "name": "cgal",
       "default-features": false
     },
-    {
-      "name": "vcpkg-cmake",
-      "host": true
-    },
     "eigen3",
     "glew",
     "glfw3",
@@ -32,6 +28,10 @@
     },
     "tiff",
     "vcglib",
+    {
+      "name": "vcpkg-cmake",
+      "host": true
+    },
     "zlib"
   ],
   "features": {

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 33f02c0ae50c262da487d21ace4f5d67ae949c18 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/o-/openmvs.json b/versions/o-/openmvs.json
index a3c313b..8ce9dd4 100644
--- a/versions/o-/openmvs.json
+++ b/versions/o-/openmvs.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "054882d44e2b35b2301b634dacc410bb3c48665f",
+      "git-tree": "168233263a9b959a9a19f1eb2d6f462d5257d18f",
       "version": "1.1.1",
       "port-version": 1
     },

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

• ports/openmvs/portfile.cmake