-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[boost-gil] remove dependency boost-filesystem #20575
Conversation
This dependency is optional and only used to build and run tests and examples. See https://github.com/boostorg/gil#requirements However, there is also BOOST_GIL_IO_ADD_FS_PATH_SUPPORT which enables boost::filesystem::path support for IO functions, but since users have to define it manually, they must install the dependency manually, too.
I don't like doing this without making sure that this doesn't change over time when people run |
@strega-nil-ms is |
Yes the boost |
@autoantwort I see. So dependencies of boost libraries are determined by their includes and even though |
cc @yurybura |
I've made the required changes to generate-ports.ps1 |
scripts/boost/generate-ports.ps1
Outdated
@@ -24,6 +24,7 @@ else { | |||
# Clear this array when moving to a new boost version | |||
$portVersions = @{ | |||
#e.g. "boost-asio" = 1; | |||
"boost-gil" = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After re-run generation script the dependency will be added again. Script's logic must be modified too. I can do this in #20432.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done by @strega-nil-ms )
#20432 restores compat between generate-ports.ps1 and all boost ports and should land first. |
# Conflicts: # scripts/boost/generate-ports.ps1
I pushed a merge with master to get #20432 and ensured that generate-ports.ps1 results in no edits |
Thanks! |
This dependency is optional and only used to build and run tests and examples.
See https://github.com/boostorg/gil#requirements
However, there is also BOOST_GIL_IO_ADD_FS_PATH_SUPPORT which enables
boost::filesystem::path support for IO functions, but since users have to define
it manually, they must install the dependency manually, too.
A little benefit is that there is no need to build anything anymore: GIL itself and all its dependencies are header-only.