Skip to content

[many ports] call vcpkg_fixup_pkgconfig()#20953

Merged
BillyONeal merged 4 commits into
microsoft:masterfrom
autoantwort:many-ports-add-ppg-config
Oct 27, 2021
Merged

[many ports] call vcpkg_fixup_pkgconfig()#20953
BillyONeal merged 4 commits into
microsoft:masterfrom
autoantwort:many-ports-add-ppg-config

Conversation

@autoantwort

Copy link
Copy Markdown
Contributor

The ports generate pc files, but don't call vcpkg_fixup_pkgconfig() so that there are absolute paths in the pc files

The port list was generated like described here

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/arrow/portfile.cmake
  • ports/bcg729/portfile.cmake
  • ports/bdwgc/portfile.cmake
  • ports/blitz/portfile.cmake
  • ports/blosc/portfile.cmake
  • ports/brpc/portfile.cmake
  • ports/bullet3/portfile.cmake
  • ports/capnproto/portfile.cmake
  • ports/ccd/portfile.cmake
  • ports/charls/portfile.cmake
  • ports/check/portfile.cmake
  • ports/clblast/portfile.cmake
  • ports/cmocka/portfile.cmake
  • ports/coin/portfile.cmake
  • ports/collada-dom/portfile.cmake
  • ports/cpp-redis/portfile.cmake
  • ports/cppcodec/portfile.cmake
  • ports/curlpp/portfile.cmake
  • ports/cutelyst2/portfile.cmake
  • ports/dlib/portfile.cmake
  • ports/fcl/portfile.cmake
  • ports/flann/portfile.cmake
  • ports/flatbuffers/portfile.cmake
  • ports/fluidlite/portfile.cmake
  • ports/folly/portfile.cmake
  • ports/freeglut/portfile.cmake
  • ports/freeopcua/portfile.cmake
  • ports/functions-framework-cpp/portfile.cmake
  • ports/geogram/portfile.cmake
  • ports/geographiclib/portfile.cmake
  • ports/gflags/portfile.cmake
  • ports/graphite2/portfile.cmake
  • ports/graphqlparser/portfile.cmake
  • ports/grpc/portfile.cmake
  • ports/hyperscan/portfile.cmake
  • ports/igraph/portfile.cmake
  • ports/iniparser/portfile.cmake
  • ports/itpp/portfile.cmake
  • ports/jansson/portfile.cmake
  • ports/json11/portfile.cmake
  • ports/libcerf/portfile.cmake
  • ports/libconfuse/portfile.cmake
  • ports/libevent/portfile.cmake
  • ports/libevhtp/portfile.cmake
  • ports/libftdi1/portfile.cmake
  • ports/libgta/portfile.cmake
  • ports/libheif/portfile.cmake
  • ports/libkml/portfile.cmake
  • ports/liblemon/portfile.cmake
  • ports/liblo/portfile.cmake
  • ports/libmikmod/portfile.cmake
  • ports/librdkafka/portfile.cmake
  • ports/libtins/portfile.cmake
  • ports/libtorrent/portfile.cmake
  • ports/mongo-cxx-driver/portfile.cmake
  • ports/mosquitto/portfile.cmake
  • ports/msgpack/portfile.cmake
  • ports/msgpack11/portfile.cmake
  • ports/muparser/portfile.cmake
  • ports/nanomsg/portfile.cmake
  • ports/nlopt/portfile.cmake
  • ports/octomap/portfile.cmake
  • ports/ode/portfile.cmake
  • ports/ois/portfile.cmake
  • ports/opencc/portfile.cmake
  • ports/orocos-kdl/portfile.cmake
  • ports/p-ranav-csv2/portfile.cmake
  • ports/pcl/portfile.cmake
  • ports/plplot/portfile.cmake
  • ports/poppler/portfile.cmake
  • ports/portaudio/portfile.cmake
  • ports/ppconsul/portfile.cmake
  • ports/qca/portfile.cmake
  • ports/raylib/portfile.cmake
  • ports/rpclib/portfile.cmake
  • ports/sais/portfile.cmake
  • ports/sdformat6/portfile.cmake
  • ports/sentencepiece/portfile.cmake
  • ports/sol2/portfile.cmake
  • ports/stxxl/portfile.cmake
  • ports/superlu/portfile.cmake
  • ports/thrift/portfile.cmake
  • ports/xerces-c/portfile.cmake
  • ports/zziplib/portfile.cmake

@autoantwort
autoantwort force-pushed the many-ports-add-ppg-config branch from 197d9de to c418ca5 Compare October 24, 2021 01:00

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for matio but no changes to version or port version.
-- Version: 1.5.19#1
-- Old SHA: c11c8ba1ca5c7f0286165d497088779ec0df756a
-- New SHA: 85530d0a0303eafc14789066aecfd161ce90feef
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 2169ab765b49cfc5cd7eddfc8ff3e579326776f8 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/m-/matio.json b/versions/m-/matio.json
index 87ab697..74bf34b 100644
--- a/versions/m-/matio.json
+++ b/versions/m-/matio.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "85530d0a0303eafc14789066aecfd161ce90feef",
+      "git-tree": "c11c8ba1ca5c7f0286165d497088779ec0df756a",
       "version-semver": "1.5.19",
       "port-version": 1
     },

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/arrow/portfile.cmake
  • ports/bcg729/portfile.cmake
  • ports/bdwgc/portfile.cmake
  • ports/blitz/portfile.cmake
  • ports/blosc/portfile.cmake
  • ports/brpc/portfile.cmake
  • ports/bullet3/portfile.cmake
  • ports/capnproto/portfile.cmake
  • ports/ccd/portfile.cmake
  • ports/charls/portfile.cmake
  • ports/check/portfile.cmake
  • ports/clblast/portfile.cmake
  • ports/cmocka/portfile.cmake
  • ports/coin/portfile.cmake
  • ports/collada-dom/portfile.cmake
  • ports/cpp-redis/portfile.cmake
  • ports/cppcodec/portfile.cmake
  • ports/curlpp/portfile.cmake
  • ports/cutelyst2/portfile.cmake
  • ports/dlib/portfile.cmake
  • ports/fcl/portfile.cmake
  • ports/flann/portfile.cmake
  • ports/flatbuffers/portfile.cmake
  • ports/fluidlite/portfile.cmake
  • ports/folly/portfile.cmake
  • ports/freeglut/portfile.cmake
  • ports/freeopcua/portfile.cmake
  • ports/functions-framework-cpp/portfile.cmake
  • ports/geogram/portfile.cmake
  • ports/geographiclib/portfile.cmake
  • ports/gflags/portfile.cmake
  • ports/graphite2/portfile.cmake
  • ports/graphqlparser/portfile.cmake
  • ports/grpc/portfile.cmake
  • ports/gtest/portfile.cmake
  • ports/hyperscan/portfile.cmake
  • ports/igraph/portfile.cmake
  • ports/iniparser/portfile.cmake
  • ports/itpp/portfile.cmake
  • ports/jansson/portfile.cmake
  • ports/json11/portfile.cmake
  • ports/libcerf/portfile.cmake
  • ports/libconfuse/portfile.cmake
  • ports/libevent/portfile.cmake
  • ports/libevhtp/portfile.cmake
  • ports/libftdi1/portfile.cmake
  • ports/libgta/portfile.cmake
  • ports/libheif/portfile.cmake
  • ports/libkml/portfile.cmake
  • ports/liblemon/portfile.cmake
  • ports/liblo/portfile.cmake
  • ports/libmikmod/portfile.cmake
  • ports/librdkafka/portfile.cmake
  • ports/libtins/portfile.cmake
  • ports/libtorrent/portfile.cmake
  • ports/log4cpp/portfile.cmake
  • ports/mongo-cxx-driver/portfile.cmake
  • ports/mosquitto/portfile.cmake
  • ports/msgpack/portfile.cmake
  • ports/msgpack11/portfile.cmake
  • ports/muparser/portfile.cmake
  • ports/nanomsg/portfile.cmake
  • ports/nlopt/portfile.cmake
  • ports/octomap/portfile.cmake
  • ports/ode/portfile.cmake
  • ports/ois/portfile.cmake
  • ports/opencc/portfile.cmake
  • ports/openmesh/portfile.cmake
  • ports/orocos-kdl/portfile.cmake
  • ports/p-ranav-csv2/portfile.cmake
  • ports/pcl/portfile.cmake
  • ports/plplot/portfile.cmake
  • ports/polyclipping/portfile.cmake
  • ports/poppler/portfile.cmake
  • ports/portaudio/portfile.cmake
  • ports/ppconsul/portfile.cmake
  • ports/qca/portfile.cmake
  • ports/raylib/portfile.cmake
  • ports/rpclib/portfile.cmake
  • ports/sais/portfile.cmake
  • ports/sdformat6/portfile.cmake
  • ports/sentencepiece/portfile.cmake
  • ports/sol2/portfile.cmake
  • ports/stxxl/portfile.cmake
  • ports/superlu/portfile.cmake
  • ports/thrift/portfile.cmake
  • ports/tidy-html5/portfile.cmake
  • ports/tinyobjloader/portfile.cmake
  • ports/tinyply/portfile.cmake
  • ports/tlx/portfile.cmake
  • ports/tmxparser/portfile.cmake
  • ports/unittest-cpp/portfile.cmake
  • ports/wampcc/portfile.cmake
  • ports/woff2/portfile.cmake
  • ports/xalan-c/portfile.cmake
  • ports/xerces-c/portfile.cmake
  • ports/xlnt/portfile.cmake
  • ports/xtensor-fftw/portfile.cmake
  • ports/z3/portfile.cmake
  • ports/zyre/portfile.cmake
  • ports/zziplib/portfile.cmake

@autoantwort
autoantwort force-pushed the many-ports-add-ppg-config branch from c418ca5 to 38eb220 Compare October 24, 2021 01:18

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/arrow/portfile.cmake
  • ports/bcg729/portfile.cmake
  • ports/bdwgc/portfile.cmake
  • ports/blitz/portfile.cmake
  • ports/blosc/portfile.cmake
  • ports/brpc/portfile.cmake
  • ports/bullet3/portfile.cmake
  • ports/capnproto/portfile.cmake
  • ports/ccd/portfile.cmake
  • ports/charls/portfile.cmake
  • ports/check/portfile.cmake
  • ports/clblast/portfile.cmake
  • ports/cmocka/portfile.cmake
  • ports/coin/portfile.cmake
  • ports/collada-dom/portfile.cmake
  • ports/cpp-redis/portfile.cmake
  • ports/cppcodec/portfile.cmake
  • ports/curlpp/portfile.cmake
  • ports/cutelyst2/portfile.cmake
  • ports/dlib/portfile.cmake
  • ports/fcl/portfile.cmake
  • ports/flann/portfile.cmake
  • ports/flatbuffers/portfile.cmake
  • ports/fluidlite/portfile.cmake
  • ports/folly/portfile.cmake
  • ports/freeglut/portfile.cmake
  • ports/freeopcua/portfile.cmake
  • ports/functions-framework-cpp/portfile.cmake
  • ports/geogram/portfile.cmake
  • ports/geographiclib/portfile.cmake
  • ports/gflags/portfile.cmake
  • ports/graphite2/portfile.cmake
  • ports/graphqlparser/portfile.cmake
  • ports/grpc/portfile.cmake
  • ports/gtest/portfile.cmake
  • ports/hyperscan/portfile.cmake
  • ports/igraph/portfile.cmake
  • ports/iniparser/portfile.cmake
  • ports/itpp/portfile.cmake
  • ports/jansson/portfile.cmake
  • ports/json11/portfile.cmake
  • ports/libcerf/portfile.cmake
  • ports/libconfuse/portfile.cmake
  • ports/libevent/portfile.cmake
  • ports/libevhtp/portfile.cmake
  • ports/libftdi1/portfile.cmake
  • ports/libgta/portfile.cmake
  • ports/libheif/portfile.cmake
  • ports/libkml/portfile.cmake
  • ports/liblemon/portfile.cmake
  • ports/liblo/portfile.cmake
  • ports/libmikmod/portfile.cmake
  • ports/librdkafka/portfile.cmake
  • ports/libtins/portfile.cmake
  • ports/libtorrent/portfile.cmake
  • ports/log4cpp/portfile.cmake
  • ports/mongo-cxx-driver/portfile.cmake
  • ports/mosquitto/portfile.cmake
  • ports/msgpack/portfile.cmake
  • ports/msgpack11/portfile.cmake
  • ports/muparser/portfile.cmake
  • ports/nanomsg/portfile.cmake
  • ports/nlopt/portfile.cmake
  • ports/octomap/portfile.cmake
  • ports/ode/portfile.cmake
  • ports/ois/portfile.cmake
  • ports/opencc/portfile.cmake
  • ports/openmesh/portfile.cmake
  • ports/orocos-kdl/portfile.cmake
  • ports/p-ranav-csv2/portfile.cmake
  • ports/pcl/portfile.cmake
  • ports/plplot/portfile.cmake
  • ports/polyclipping/portfile.cmake
  • ports/poppler/portfile.cmake
  • ports/portaudio/portfile.cmake
  • ports/ppconsul/portfile.cmake
  • ports/qca/portfile.cmake
  • ports/raylib/portfile.cmake
  • ports/rpclib/portfile.cmake
  • ports/sais/portfile.cmake
  • ports/sdformat6/portfile.cmake
  • ports/sentencepiece/portfile.cmake
  • ports/sol2/portfile.cmake
  • ports/stxxl/portfile.cmake
  • ports/superlu/portfile.cmake
  • ports/thrift/portfile.cmake
  • ports/tidy-html5/portfile.cmake
  • ports/tinyobjloader/portfile.cmake
  • ports/tinyply/portfile.cmake
  • ports/tlx/portfile.cmake
  • ports/tmxparser/portfile.cmake
  • ports/unittest-cpp/portfile.cmake
  • ports/wampcc/portfile.cmake
  • ports/woff2/portfile.cmake
  • ports/xalan-c/portfile.cmake
  • ports/xerces-c/portfile.cmake
  • ports/xlnt/portfile.cmake
  • ports/xtensor-fftw/portfile.cmake
  • ports/z3/portfile.cmake
  • ports/zyre/portfile.cmake
  • ports/zziplib/portfile.cmake

@autoantwort
autoantwort force-pushed the many-ports-add-ppg-config branch from 38eb220 to 3f0e3e0 Compare October 24, 2021 01:47

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/arrow/portfile.cmake
  • ports/avro-c/portfile.cmake
  • ports/bcg729/portfile.cmake
  • ports/bdwgc/portfile.cmake
  • ports/blitz/portfile.cmake
  • ports/blosc/portfile.cmake
  • ports/brigand/portfile.cmake
  • ports/brpc/portfile.cmake
  • ports/bullet3/portfile.cmake
  • ports/capnproto/portfile.cmake
  • ports/ccd/portfile.cmake
  • ports/charls/portfile.cmake
  • ports/check/portfile.cmake
  • ports/clblast/portfile.cmake
  • ports/cmocka/portfile.cmake
  • ports/coin/portfile.cmake
  • ports/collada-dom/portfile.cmake
  • ports/cpp-redis/portfile.cmake
  • ports/cppcodec/portfile.cmake
  • ports/curlpp/portfile.cmake
  • ports/cutelyst2/portfile.cmake
  • ports/dlib/portfile.cmake
  • ports/fcl/portfile.cmake
  • ports/flann/portfile.cmake
  • ports/flatbuffers/portfile.cmake
  • ports/fluidlite/portfile.cmake
  • ports/folly/portfile.cmake
  • ports/freeglut/portfile.cmake
  • ports/freeopcua/portfile.cmake
  • ports/functions-framework-cpp/portfile.cmake
  • ports/geogram/portfile.cmake
  • ports/geographiclib/portfile.cmake
  • ports/getdns/portfile.cmake
  • ports/gflags/portfile.cmake
  • ports/graphite2/portfile.cmake
  • ports/graphqlparser/portfile.cmake
  • ports/grpc/portfile.cmake
  • ports/gtest/portfile.cmake
  • ports/hyperscan/portfile.cmake
  • ports/igraph/portfile.cmake
  • ports/iniparser/portfile.cmake
  • ports/itpp/portfile.cmake
  • ports/jansson/portfile.cmake
  • ports/json11/portfile.cmake
  • ports/libcerf/portfile.cmake
  • ports/libconfuse/portfile.cmake
  • ports/libevent/portfile.cmake
  • ports/libevhtp/portfile.cmake
  • ports/libfreenect2/portfile.cmake
  • ports/libftdi/portfile.cmake
  • ports/libftdi1/portfile.cmake
  • ports/libgta/portfile.cmake
  • ports/libheif/portfile.cmake
  • ports/libkml/portfile.cmake
  • ports/liblemon/portfile.cmake
  • ports/liblo/portfile.cmake
  • ports/libmikmod/portfile.cmake
  • ports/librdkafka/portfile.cmake
  • ports/libtins/portfile.cmake
  • ports/libtorrent/portfile.cmake
  • ports/log4cpp/portfile.cmake
  • ports/mongo-cxx-driver/portfile.cmake
  • ports/mosquitto/portfile.cmake
  • ports/msgpack/portfile.cmake
  • ports/msgpack11/portfile.cmake
  • ports/muparser/portfile.cmake
  • ports/nanomsg/portfile.cmake
  • ports/nlopt/portfile.cmake
  • ports/octomap/portfile.cmake
  • ports/ode/portfile.cmake
  • ports/ois/portfile.cmake
  • ports/opencc/portfile.cmake
  • ports/openmesh/portfile.cmake
  • ports/orocos-kdl/portfile.cmake
  • ports/osg-qt/portfile.cmake
  • ports/osg/portfile.cmake
  • ports/p-ranav-csv2/portfile.cmake
  • ports/pcl/portfile.cmake
  • ports/pdal/portfile.cmake
  • ports/plplot/portfile.cmake
  • ports/polyclipping/portfile.cmake
  • ports/ponder/portfile.cmake
  • ports/poppler/portfile.cmake
  • ports/portaudio/portfile.cmake
  • ports/ppconsul/portfile.cmake
  • ports/qca/portfile.cmake
  • ports/raylib/portfile.cmake
  • ports/rpclib/portfile.cmake
  • ports/sais/portfile.cmake
  • ports/sdformat6/portfile.cmake
  • ports/sdl2pp/portfile.cmake
  • ports/sentencepiece/portfile.cmake
  • ports/sol2/portfile.cmake
  • ports/stxxl/portfile.cmake
  • ports/superlu/portfile.cmake
  • ports/thrift/portfile.cmake
  • ports/tidy-html5/portfile.cmake
  • ports/tinyobjloader/portfile.cmake
  • ports/tinyply/portfile.cmake
  • ports/tlx/portfile.cmake
  • ports/tmxparser/portfile.cmake
  • ports/unittest-cpp/portfile.cmake
  • ports/wampcc/portfile.cmake
  • ports/woff2/portfile.cmake
  • ports/xalan-c/portfile.cmake
  • ports/xerces-c/portfile.cmake
  • ports/xlnt/portfile.cmake
  • ports/xtensor-fftw/portfile.cmake
  • ports/z3/portfile.cmake
  • ports/zyre/portfile.cmake
  • ports/zziplib/portfile.cmake

@autoantwort
autoantwort force-pushed the many-ports-add-ppg-config branch from 3f0e3e0 to 36af78c Compare October 24, 2021 11:01

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/arrow/portfile.cmake
  • ports/bcg729/portfile.cmake
  • ports/bdwgc/portfile.cmake
  • ports/blitz/portfile.cmake
  • ports/blosc/portfile.cmake
  • ports/brpc/portfile.cmake
  • ports/bullet3/portfile.cmake
  • ports/capnproto/portfile.cmake
  • ports/ccd/portfile.cmake
  • ports/charls/portfile.cmake
  • ports/check/portfile.cmake
  • ports/clblast/portfile.cmake
  • ports/cmocka/portfile.cmake
  • ports/coin/portfile.cmake
  • ports/collada-dom/portfile.cmake
  • ports/cpp-redis/portfile.cmake
  • ports/cppcodec/portfile.cmake
  • ports/curlpp/portfile.cmake
  • ports/dlib/portfile.cmake
  • ports/fcl/portfile.cmake
  • ports/flann/portfile.cmake
  • ports/flatbuffers/portfile.cmake
  • ports/fluidlite/portfile.cmake
  • ports/folly/portfile.cmake
  • ports/freeglut/portfile.cmake
  • ports/freeopcua/portfile.cmake
  • ports/functions-framework-cpp/portfile.cmake
  • ports/geogram/portfile.cmake
  • ports/geographiclib/portfile.cmake
  • ports/getdns/portfile.cmake
  • ports/gflags/portfile.cmake
  • ports/graphite2/portfile.cmake
  • ports/graphqlparser/portfile.cmake
  • ports/hyperscan/portfile.cmake
  • ports/igraph/portfile.cmake
  • ports/iniparser/portfile.cmake
  • ports/itpp/portfile.cmake
  • ports/jansson/portfile.cmake
  • ports/json11/portfile.cmake
  • ports/libcerf/portfile.cmake
  • ports/libconfuse/portfile.cmake
  • ports/libevent/portfile.cmake
  • ports/libevhtp/portfile.cmake
  • ports/libfreenect2/portfile.cmake
  • ports/libgta/portfile.cmake
  • ports/libkml/portfile.cmake
  • ports/liblemon/portfile.cmake
  • ports/liblo/portfile.cmake
  • ports/libmikmod/portfile.cmake
  • ports/librdkafka/portfile.cmake
  • ports/libtins/portfile.cmake
  • ports/libtorrent/portfile.cmake
  • ports/mosquitto/portfile.cmake
  • ports/msgpack/portfile.cmake
  • ports/msgpack11/portfile.cmake
  • ports/muparser/portfile.cmake
  • ports/nanomsg/portfile.cmake
  • ports/nlopt/portfile.cmake
  • ports/octomap/portfile.cmake
  • ports/ode/portfile.cmake
  • ports/ois/portfile.cmake
  • ports/opencc/portfile.cmake
  • ports/orocos-kdl/portfile.cmake
  • ports/osg/portfile.cmake
  • ports/p-ranav-csv2/portfile.cmake
  • ports/pcl/portfile.cmake
  • ports/plplot/portfile.cmake
  • ports/polyclipping/portfile.cmake
  • ports/ponder/portfile.cmake
  • ports/poppler/portfile.cmake
  • ports/portaudio/portfile.cmake
  • ports/ppconsul/portfile.cmake
  • ports/raylib/portfile.cmake
  • ports/rpclib/portfile.cmake
  • ports/sais/portfile.cmake
  • ports/sdformat6/portfile.cmake
  • ports/sentencepiece/portfile.cmake
  • ports/sol2/portfile.cmake
  • ports/stxxl/portfile.cmake
  • ports/superlu/portfile.cmake
  • ports/thrift/portfile.cmake
  • ports/tidy-html5/portfile.cmake
  • ports/tinyobjloader/portfile.cmake
  • ports/tinyply/portfile.cmake
  • ports/tlx/portfile.cmake
  • ports/tmxparser/portfile.cmake
  • ports/unittest-cpp/portfile.cmake
  • ports/wampcc/portfile.cmake
  • ports/xalan-c/portfile.cmake
  • ports/xerces-c/portfile.cmake
  • ports/xlnt/portfile.cmake
  • ports/xtensor-fftw/portfile.cmake
  • ports/z3/portfile.cmake
  • ports/zyre/portfile.cmake
  • ports/zziplib/portfile.cmake

The ports generate pc files, but don't call vcpkg_fixup_pkgconfig() so that there are absolute paths in the pc files
@autoantwort
autoantwort force-pushed the many-ports-add-ppg-config branch from 36af78c to 514eb72 Compare October 24, 2021 12:08

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/arrow/portfile.cmake
  • ports/bcg729/portfile.cmake
  • ports/bdwgc/portfile.cmake
  • ports/blitz/portfile.cmake
  • ports/blosc/portfile.cmake
  • ports/brpc/portfile.cmake
  • ports/bullet3/portfile.cmake
  • ports/capnproto/portfile.cmake
  • ports/ccd/portfile.cmake
  • ports/charls/portfile.cmake
  • ports/check/portfile.cmake
  • ports/clblast/portfile.cmake
  • ports/cmocka/portfile.cmake
  • ports/coin/portfile.cmake
  • ports/collada-dom/portfile.cmake
  • ports/cpp-redis/portfile.cmake
  • ports/cppcodec/portfile.cmake
  • ports/curlpp/portfile.cmake
  • ports/dlib/portfile.cmake
  • ports/fcl/portfile.cmake
  • ports/flann/portfile.cmake
  • ports/flatbuffers/portfile.cmake
  • ports/fluidlite/portfile.cmake
  • ports/folly/portfile.cmake
  • ports/freeglut/portfile.cmake
  • ports/freeopcua/portfile.cmake
  • ports/functions-framework-cpp/portfile.cmake
  • ports/geogram/portfile.cmake
  • ports/geographiclib/portfile.cmake
  • ports/getdns/portfile.cmake
  • ports/gflags/portfile.cmake
  • ports/graphite2/portfile.cmake
  • ports/graphqlparser/portfile.cmake
  • ports/hyperscan/portfile.cmake
  • ports/igraph/portfile.cmake
  • ports/iniparser/portfile.cmake
  • ports/itpp/portfile.cmake
  • ports/jansson/portfile.cmake
  • ports/json11/portfile.cmake
  • ports/libcerf/portfile.cmake
  • ports/libconfuse/portfile.cmake
  • ports/libevent/portfile.cmake
  • ports/libevhtp/portfile.cmake
  • ports/libfreenect2/portfile.cmake
  • ports/libgta/portfile.cmake
  • ports/libkml/portfile.cmake
  • ports/liblemon/portfile.cmake
  • ports/liblo/portfile.cmake
  • ports/libmikmod/portfile.cmake
  • ports/librdkafka/portfile.cmake
  • ports/libtins/portfile.cmake
  • ports/libtorrent/portfile.cmake
  • ports/mosquitto/portfile.cmake
  • ports/msgpack/portfile.cmake
  • ports/msgpack11/portfile.cmake
  • ports/muparser/portfile.cmake
  • ports/nanomsg/portfile.cmake
  • ports/nlopt/portfile.cmake
  • ports/octomap/portfile.cmake
  • ports/ode/portfile.cmake
  • ports/ois/portfile.cmake
  • ports/opencc/portfile.cmake
  • ports/orocos-kdl/portfile.cmake
  • ports/osg/portfile.cmake
  • ports/p-ranav-csv2/portfile.cmake
  • ports/pcl/portfile.cmake
  • ports/plplot/portfile.cmake
  • ports/polyclipping/portfile.cmake
  • ports/ponder/portfile.cmake
  • ports/poppler/portfile.cmake
  • ports/portaudio/portfile.cmake
  • ports/ppconsul/portfile.cmake
  • ports/raylib/portfile.cmake
  • ports/rpclib/portfile.cmake
  • ports/sais/portfile.cmake
  • ports/sdformat6/portfile.cmake
  • ports/sentencepiece/portfile.cmake
  • ports/sol2/portfile.cmake
  • ports/stxxl/portfile.cmake
  • ports/superlu/portfile.cmake
  • ports/thrift/portfile.cmake
  • ports/tidy-html5/portfile.cmake
  • ports/tinyobjloader/portfile.cmake
  • ports/tinyply/portfile.cmake
  • ports/tlx/portfile.cmake
  • ports/tmxparser/portfile.cmake
  • ports/unittest-cpp/portfile.cmake
  • ports/wampcc/portfile.cmake
  • ports/xalan-c/portfile.cmake
  • ports/xerces-c/portfile.cmake
  • ports/xlnt/portfile.cmake
  • ports/xtensor-fftw/portfile.cmake
  • ports/z3/portfile.cmake
  • ports/zyre/portfile.cmake
  • ports/zziplib/portfile.cmake

@PhoebeHui PhoebeHui left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks for the PR!

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Oct 25, 2021
@PhoebeHui

Copy link
Copy Markdown
Contributor

Fixes #20469

# Conflicts:
#	ports/aom/vcpkg.json
#	ports/capnproto/portfile.cmake
#	ports/capnproto/vcpkg.json
#	ports/fcl/portfile.cmake
#	ports/fcl/vcpkg.json
#	ports/libbson/vcpkg.json
#	ports/mongo-c-driver/portfile.cmake
#	ports/mongo-c-driver/vcpkg.json
#	versions/a-/aom.json
#	versions/a-/armadillo.json
#	versions/baseline.json
#	versions/c-/capnproto.json
#	versions/f-/fcl.json
#	versions/l-/libbson.json
#	versions/m-/mongo-c-driver.json
#	versions/p-/polyclipping.json

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/arrow/portfile.cmake
  • ports/bcg729/portfile.cmake
  • ports/bdwgc/portfile.cmake
  • ports/blitz/portfile.cmake
  • ports/blosc/portfile.cmake
  • ports/brpc/portfile.cmake
  • ports/bullet3/portfile.cmake
  • ports/ccd/portfile.cmake
  • ports/charls/portfile.cmake
  • ports/check/portfile.cmake
  • ports/clblast/portfile.cmake
  • ports/cmocka/portfile.cmake
  • ports/coin/portfile.cmake
  • ports/collada-dom/portfile.cmake
  • ports/cpp-redis/portfile.cmake
  • ports/cppcodec/portfile.cmake
  • ports/curlpp/portfile.cmake
  • ports/dlib/portfile.cmake
  • ports/flann/portfile.cmake
  • ports/flatbuffers/portfile.cmake
  • ports/fluidlite/portfile.cmake
  • ports/folly/portfile.cmake
  • ports/freeglut/portfile.cmake
  • ports/freeopcua/portfile.cmake
  • ports/functions-framework-cpp/portfile.cmake
  • ports/geogram/portfile.cmake
  • ports/geographiclib/portfile.cmake
  • ports/getdns/portfile.cmake
  • ports/gflags/portfile.cmake
  • ports/graphite2/portfile.cmake
  • ports/graphqlparser/portfile.cmake
  • ports/hyperscan/portfile.cmake
  • ports/igraph/portfile.cmake
  • ports/iniparser/portfile.cmake
  • ports/itpp/portfile.cmake
  • ports/jansson/portfile.cmake
  • ports/json11/portfile.cmake
  • ports/libcerf/portfile.cmake
  • ports/libconfuse/portfile.cmake
  • ports/libevent/portfile.cmake
  • ports/libevhtp/portfile.cmake
  • ports/libfreenect2/portfile.cmake
  • ports/libgta/portfile.cmake
  • ports/libkml/portfile.cmake
  • ports/liblemon/portfile.cmake
  • ports/liblo/portfile.cmake
  • ports/libmikmod/portfile.cmake
  • ports/librdkafka/portfile.cmake
  • ports/libtins/portfile.cmake
  • ports/libtorrent/portfile.cmake
  • ports/mosquitto/portfile.cmake
  • ports/msgpack/portfile.cmake
  • ports/msgpack11/portfile.cmake
  • ports/muparser/portfile.cmake
  • ports/nanomsg/portfile.cmake
  • ports/nlopt/portfile.cmake
  • ports/octomap/portfile.cmake
  • ports/ode/portfile.cmake
  • ports/ois/portfile.cmake
  • ports/opencc/portfile.cmake
  • ports/orocos-kdl/portfile.cmake
  • ports/osg/portfile.cmake
  • ports/p-ranav-csv2/portfile.cmake
  • ports/pcl/portfile.cmake
  • ports/plplot/portfile.cmake
  • ports/polyclipping/portfile.cmake
  • ports/ponder/portfile.cmake
  • ports/poppler/portfile.cmake
  • ports/portaudio/portfile.cmake
  • ports/ppconsul/portfile.cmake
  • ports/raylib/portfile.cmake
  • ports/rpclib/portfile.cmake
  • ports/sais/portfile.cmake
  • ports/sdformat6/portfile.cmake
  • ports/sentencepiece/portfile.cmake
  • ports/sol2/portfile.cmake
  • ports/stxxl/portfile.cmake
  • ports/superlu/portfile.cmake
  • ports/thrift/portfile.cmake
  • ports/tidy-html5/portfile.cmake
  • ports/tinyobjloader/portfile.cmake
  • ports/tinyply/portfile.cmake
  • ports/tlx/portfile.cmake
  • ports/tmxparser/portfile.cmake
  • ports/unittest-cpp/portfile.cmake
  • ports/wampcc/portfile.cmake
  • ports/xalan-c/portfile.cmake
  • ports/xerces-c/portfile.cmake
  • ports/xlnt/portfile.cmake
  • ports/xtensor-fftw/portfile.cmake
  • ports/z3/portfile.cmake
  • ports/zyre/portfile.cmake
  • ports/zziplib/portfile.cmake

@BillyONeal
BillyONeal merged commit e7e328c into microsoft:master Oct 27, 2021
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Oct 28, 2021
[many ports] call vcpkg_fixup_pkgconfig() (microsoft#20953)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants