-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pcre2] fetch from github #21193
[pcre2] fetch from github #21193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/pcre2/portfile.cmake
Hello, I got pcre2 hash check error. Building package pcre2[core]:x64-windows... [DEBUG] Exiting after %s (%d us) |
Remark: This should not have passed CI. The difference of the SHA512 between the zip file and the tar.gz must be detected. |
I guess this went unnoticed due to "asset caching". If the cache key is just the file name, changes in content don't invalidate the cache. This affects local usage ( |
Before it was a .zip, now a .tar.gz, that shouldn't be affected by caching. |
I will submit pr to fix this bug |
couldn't agree more |
The problem is that part of the reason for asset caching is to prevent a failure of an external server from preventing all PR progress, and to prevent very very slow external servers from bringing the big build machines to a halt waiting to download those pieces. I would love to have the best of both worlds somehow but I don't see obvious solutions. |
Maybe I'm missing something, but wouldn't it help to make the filename or download url the cache key? Currently it's the file basename or port version? |
Currently it is just the SHA. It was intentionally not tied to a given URI because there are often multiple sources for a given thing. There is probably a middle ground that can be struck here but it's not super obvious... |
Describe the pull request
What does your PR fix?
Fixes current build errors of pcre2 because https://ftp.pcre.org is not reachable. This only changes the download source of the code.
According to https://www.pcre.org/ the home is now github, so there we go get it now.
This does not change the version even though a new one is available but that fails to build at the moment. Step by step.
Which triplets are supported/not supported? Have you updated the CI baseline?
all
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes