[vcpkg_fail_port_install] Deprecate function #21489
Conversation
JackBoosY
added
category:vcpkg-feature
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
But maybe instead of printing the message for every end user suggest the change when creating PRs like in #20142 |
|
I have created #21502 as an alternative |
|
If this is resurrected it should respond to |
…jack/depreciate-vcpkg-fail-port-install
|
|
JackBoosY
added
the
depends:different-pr
JackBoosY
removed
the
depends:different-pr
That is done. |
|
See https://github.com/microsoft/vcpkg/search?q=vcpkg_fail_port_install&type=, Could you remove it in other three files as well? |
| #]===] | ||
|
|
||
| message("${Z_VCPKG_BACKCOMPAT_MESSAGE_LEVEL}" "vcpkg_fail_port_install has been removed and all values should be moved by adding `supports` field to manifest file or directly adding `${PORT}:${FAILED_TRIPLET}=fail` to _scripts/ci.baseline.txt_.\nPlease remove `vcpkg_fail_port_install(...)`.\n") |
There was a problem hiding this comment.
This should be
z_vcpkg_deprecation_message(".... has been deprecated in favor of ....")
as the first directive inside the function, not at global scope.
There was a problem hiding this comment.
That is not consistent with how it works for vcpkg_common_functions. I observe z_vcpkg_deprecation_message is not hooked up to Z_VCPKG_BACKCOMPAT_MESSAGE_LEVEL and thus not to --prohibit-backcompat-features which is undesirable here.
Co-authored-by: autoantwort <41973254+autoantwort@users.noreply.github.com>
| @@ -40,6 +42,8 @@ Library linkage for which the build should fail early. | |||
| #]===] | |||
|
|
|||
| function(vcpkg_fail_port_install) | |||
| z_vcpkg_deprecation_message("vcpkg_fail_port_install has been removed and all values should be moved by adding `supports` field to manifest file or directly adding `${PORT}:${FAILED_TRIPLET}=fail` to _scripts/ci.baseline.txt_.\nPlease remove `vcpkg_fail_port_install(...)`.\n") | |||
There was a problem hiding this comment.
I was incorrect about this needing to be z_vcpkg_deprecation_message -- it should be the originally proposed message("${Z_VCPKG_BACKCOMPAT_MESSAGE_LEVEL}" ...) form (though this is the right place to put it).
…-vcpkg-fail-port-install
…with `--prohibit-backcompat-features`.
* master: (221 commits) [vcpkg-tool] update to 2022-02-03 (microsoft#22924) [opencv4] Disable building cpufeatures since it conflict with libwebp (microsoft#22844) [rhasheq] New port (microsoft#22905) [sfml] Add arm64 patch to allow SFML to compile on apple silicon (microsoft#22937) [popsift] Fix missing Thrust include, already merged upstream. (microsoft#22929) [python3][python2] Use MKDIR_P to create directories to avoid race conditions (microsoft#22902) Added libe57format port (microsoft#22909) update polyhook2 (microsoft#22906) [botan] Fix debug info (microsoft#22911) [opentelemetry-cpp] update version to v1.2.0 (microsoft#22925) [docs] document VCPKG_INSTALLED_DIR variable (microsoft#22695) [c89stringutils] New port (microsoft#22904) [randomstr] New port (microsoft#22921) [docs] Add Authoring-script-ports.md (microsoft#22396) [vcpkg_fail_port_install] Deprecate function (microsoft#21489) [vcpkg-cmake-config] add missing TOOLS_PATH (microsoft#22863) Ace Build Windows - Missing files in include package (microsoft#22880) [opendnp3] Disable FetchContent in favor of predownloading (microsoft#22894) libraqm update to 0.9.0 (microsoft#22907) [google-cloud-cpp] update to latest release (v1.36.0) (microsoft#22897) ...
Since we have now used keyword
supportsto abort the unsupported triplet build when analyzing the port paragraph, deprecate this function.Related vcpkg-tool changes: microsoft/vcpkg-tool#184.