New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg-cmake-config] add missing TOOLS_PATH #22863
[vcpkg-cmake-config] add missing TOOLS_PATH #22863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/vcpkg-cmake-config/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/vcpkg-cmake-config/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/vcpkg-cmake-config/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/vcpkg-cmake-config/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
@@ -63,6 +64,9 @@ function(vcpkg_cmake_config_fixup) | |||
if(NOT arg_CONFIG_PATH) | |||
set(arg_CONFIG_PATH "share/${arg_PACKAGE_NAME}") | |||
endif() | |||
if(NOT arg_TOOLS_PATH) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hrmm, this should be if(NOT DEFINED arg_TOOLS_PATH)
, but I won't ask you to change this for now.
Thank you @Neumann-A ! |
* master: (221 commits) [vcpkg-tool] update to 2022-02-03 (microsoft#22924) [opencv4] Disable building cpufeatures since it conflict with libwebp (microsoft#22844) [rhasheq] New port (microsoft#22905) [sfml] Add arm64 patch to allow SFML to compile on apple silicon (microsoft#22937) [popsift] Fix missing Thrust include, already merged upstream. (microsoft#22929) [python3][python2] Use MKDIR_P to create directories to avoid race conditions (microsoft#22902) Added libe57format port (microsoft#22909) update polyhook2 (microsoft#22906) [botan] Fix debug info (microsoft#22911) [opentelemetry-cpp] update version to v1.2.0 (microsoft#22925) [docs] document VCPKG_INSTALLED_DIR variable (microsoft#22695) [c89stringutils] New port (microsoft#22904) [randomstr] New port (microsoft#22921) [docs] Add Authoring-script-ports.md (microsoft#22396) [vcpkg_fail_port_install] Deprecate function (microsoft#21489) [vcpkg-cmake-config] add missing TOOLS_PATH (microsoft#22863) Ace Build Windows - Missing files in include package (microsoft#22880) [opendnp3] Disable FetchContent in favor of predownloading (microsoft#22894) libraqm update to 0.9.0 (microsoft#22907) [google-cloud-cpp] update to latest release (v1.36.0) (microsoft#22897) ...
required to switch qt6 over