Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libtins] Misc fixes #21789

Merged
merged 8 commits into from
Dec 3, 2021
Merged

[libtins] Misc fixes #21789

merged 8 commits into from
Dec 3, 2021

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Dec 1, 2021 •
edited
Loading

  • What does your PR fix?

    Fixes source writes which break parallel configure. (Needed for [vcpkg-cmake] Update parallel vcpkg_cmake_configure #21507.)
    Adds explicit openssl dependency.
    Switches from winpcap to libpcap, for all platforms. (Note that winpcap is skipped in CI.)
    Disables documentation.
    Marks uwp unsuppported. (No pcap implementation seems to support this platform.)

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all but uwp, no

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    yes

@dg0yt
Copy link
Contributor Author

dg0yt commented Dec 1, 2021

Still cascading on osx. Really no osx support in libpcap?

@JonLiu1993 JonLiu1993 self-assigned this Dec 1, 2021
@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Dec 1, 2021
JonLiu1993
JonLiu1993 requested changes Dec 1, 2021
View reviewed changes
ports/libtins/vcpkg.json Outdated Show resolved Hide resolved
@JonLiu1993
Copy link
Member

@dg0yt ,Thanks for your pr, this is error log:
https://dev.azure.com/vcpkg/public/_build/results?buildId=63987&view=artifacts&pathAsName=false&type=publishedArtifacts

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Dec 2, 2021
@BillyONeal BillyONeal merged commit 5a54a43 into microsoft:master Dec 3, 2021
@BillyONeal
Copy link
Member

Thanks!

@dg0yt dg0yt deleted the libtins branch December 8, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JackBoosY JackBoosY

@JonLiu1993 JonLiu1993

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dg0yt @JonLiu1993 @BillyONeal @JackBoosY