Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8] Fix link error #21933

Merged
merged 4 commits into from
Dec 10, 2021
Merged

[v8] Fix link error #21933

merged 4 commits into from
Dec 10, 2021

Conversation

LilyWangLL
Copy link
Contributor

Fixes #21735, fix link error: Target "test" links to target "PkgConfig::GLIB2" but the target was not found.

@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Dec 9, 2021
@LilyWangLL LilyWangLL changed the title Dev/lily wang/issue21735 [v8] Fix link error Dec 9, 2021
@LilyWangLL LilyWangLL marked this pull request as ready for review December 9, 2021 09:47
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Dec 9, 2021
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 things:

  1. How do we know that the resulting build is correct without this; perhaps it actually needs glib?
  2. The failing target is a test target, can we somehow remove that completely instead of this change?

@BillyONeal BillyONeal added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Dec 10, 2021
@LilyWangLL
Copy link
Contributor Author

2 things:

  1. How do we know that the resulting build is correct without this; perhaps it actually needs glib?
  2. The failing target is a test target, can we somehow remove that completely instead of this change?

There are codes in vcpkg.json, v8 only depends on glib on Linux, glib will not install on windows.

  "dependencies": [
    {
      "name": "glib",
      "platform": "linux"
    },

And target test is from user's test code, see comment #21735 (comment).

@JackBoosY
Copy link
Contributor

@BillyONeal The user confirm this works.

@BillyONeal
Copy link
Member

And target test is from user's test code, see comment #21735 (comment).

Oh, I see, that makes sense.

@BillyONeal BillyONeal merged commit 5c54cc0 into microsoft:master Dec 10, 2021
@BillyONeal
Copy link
Member

OK, thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v8] static build failure
3 participants