-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v8] Fix link error #21933
[v8] Fix link error #21933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 things:
- How do we know that the resulting build is correct without this; perhaps it actually needs glib?
- The failing target is a test target, can we somehow remove that completely instead of this change?
There are codes in vcpkg.json, v8 only depends on glib on Linux, glib will not install on windows.
And target test is from user's test code, see comment #21735 (comment). |
@BillyONeal The user confirm this works. |
Oh, I see, that makes sense. |
OK, thanks for the fix! |
Fixes #21735, fix link error:
Target "test" links to target "PkgConfig::GLIB2" but the target was not found.