[new port] gobject-introspection 1.70.0 port #22199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
added
the
category:new-port
|
This port requires #22198 to build properly |
JackBoosY
added
the
depends:different-pr
@mkhon This should not related to the python3. |
|
How can I get #22198 to be merged to master? |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JackBoosY
removed
the
depends:different-pr
|
Please get failure logs here. |
mkhon
changed the title
JackBoosY
approved these changes
Jan 6, 2022
JackBoosY
added
info:reviewed
strega-nil-ms
suggested changes
Jan 6, 2022
| file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/share") | ||
| file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/share/man") | ||
|
|
||
| set(VCPKG_POLICY_MISMATCHED_NUMBER_OF_BINARIES enabled) # _giscanner.lib |
There was a problem hiding this comment.
Suggested change
| set(VCPKG_POLICY_MISMATCHED_NUMBER_OF_BINARIES enabled) # _giscanner.lib | |
| set(VCPKG_POLICY_MISMATCHED_NUMBER_OF_BINARIES enabled) # _giscanner.lib | |
final newline
| "version": "1.70.0", | ||
| "description": "A middleware layer between C libraries (using GObject) and language bindings.", | ||
| "homepage": "https://gi.readthedocs.io/en/latest/", | ||
| "supports": "!static & native", |
There was a problem hiding this comment.
This seems odd to me, since this seems to try hard to support non-native builds; also, why is it !static? This means that people won't be able to install on Linux or macOS by default...
There was a problem hiding this comment.
There is one missing step in supporting cross-builds: the C compiler environment is set up by vcpkg to build for target, but g-ir-scanner needs host C compiler environment which I do not know how override properly when g-ir-scanner is being executed during the build process
strega-nil-ms
added
requires:author-response
and removed
info:reviewed
|
@strega-nil-ms @JackBoosY can we proceed with this? |
|
Ping @strega-nil-ms for reply. |
|
@strega-nil-ms @JackBoosY can we proceed with this? |
strega-nil-ms
approved these changes
Jan 26, 2022
|
Alright, thanks! Sorry for missing this for so long... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New port: gobject-introspection
What does your PR fix?
Which triplets are supported/not supported? Have you updated the CI baseline?
all
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/