-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new port] gobject-introspection 1.70.0 port #22199
[new port] gobject-introspection 1.70.0 port #22199
Conversation
This port requires #22198 to build properly |
@mkhon This should not related to the python3. |
How can I get #22198 to be merged to master? |
Please get failure logs here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some stuff that needs to be done before merging; thanks for your PR!
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/share") | ||
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/share/man") | ||
|
||
set(VCPKG_POLICY_MISMATCHED_NUMBER_OF_BINARIES enabled) # _giscanner.lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set(VCPKG_POLICY_MISMATCHED_NUMBER_OF_BINARIES enabled) # _giscanner.lib | |
set(VCPKG_POLICY_MISMATCHED_NUMBER_OF_BINARIES enabled) # _giscanner.lib | |
final newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
"version": "1.70.0", | ||
"description": "A middleware layer between C libraries (using GObject) and language bindings.", | ||
"homepage": "https://gi.readthedocs.io/en/latest/", | ||
"supports": "!static & native", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems odd to me, since this seems to try hard to support non-native builds; also, why is it !static? This means that people won't be able to install on Linux or macOS by default...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one missing step in supporting cross-builds: the C compiler environment is set up by vcpkg to build for target, but g-ir-scanner needs host C compiler environment which I do not know how override properly when g-ir-scanner is being executed during the build process
@strega-nil-ms @JackBoosY can we proceed with this? |
Ping @strega-nil-ms for reply. |
@strega-nil-ms @JackBoosY can we proceed with this? |
Alright, thanks! Sorry for missing this for so long... |
New port: gobject-introspection
What does your PR fix?
Which triplets are supported/not supported? Have you updated the CI baseline?
all
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/