Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gazebo] new port #22466

Merged
merged 28 commits into from
Mar 9, 2022
Merged

[gazebo] new port #22466

merged 28 commits into from
Mar 9, 2022

Conversation

Ace314159
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    Fixes [New Port Request] Gazebo #8014

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, Yes

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/gazebo11/portfile.cmake

@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jan 11, 2022
@JonLiu1993
Copy link
Member

@Ace314159 ,Thanks for your pr, if this pr ready for review, please let me know

@Ace314159
Copy link
Contributor Author

Sorry for the delay. Although the build passes, there are still some unexpected runtime issues making the tools unusable, which I am currently trying to fix. I will mark the PR as ready for review once I fix them.

@Ace314159
Copy link
Contributor Author

Just to provide an update, I'll need to wait for this upstream PR (gazebosim/gazebo-classic#3161) to be merged before this can be ready.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for gazebo11 but no changes to version or port version.
-- Version: 2022-01-10
-- Old SHA: 6147bcd788ae49742df6bfa000d44fd8986bd113
-- New SHA: 2ea0074a90d488284742c222d13e9520dcbea42b
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@Ace314159 Ace314159 marked this pull request as ready for review January 19, 2022 21:15
@JonLiu1993 JonLiu1993 added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Jan 20, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout df40d1c476dc02d71b113e4a63c3a32b00ebb5bd -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/s-/sdformat9.json b/versions/s-/sdformat9.json
index 71fc1e2..6bfc417 100644
--- a/versions/s-/sdformat9.json
+++ b/versions/s-/sdformat9.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "545bb6ff22c2c6d0aaa5e6632492be2c4984635b",
+      "git-tree": "bb6c9ba95ef95daa6f5a2fbdfcd10f57d3b92620",
       "version": "9.4.0",
       "port-version": 5
     },

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/gazebo11/vcpkg.json
  • ports/sdformat9/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@JonLiu1993 JonLiu1993 removed info:reviewed Pull Request changes follow basic guidelines requires:author-response labels Feb 7, 2022
@JonLiu1993 JonLiu1993 added requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Feb 7, 2022
@JonLiu1993
Copy link
Member

@Ace314159 ,Have you tested the features locally?

@Ace314159
Copy link
Contributor Author

Yeah, like before, I've tested with no features and all features.

@JonLiu1993
Copy link
Member

@ras0219-msft , Could you please take a look?

@Ace314159
Copy link
Contributor Author

@ras0219-msft I'd love if you could review my PR once again. Thank you!

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Feb 21, 2022
@vicroms vicroms added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Mar 2, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for gazebo but no changes to version or port version.
-- Version: 2022-01-20
-- Old SHA: 1333c50fe6f4c7b1a2adb5af2df122eaf1abb180
-- New SHA: 983e90284c8c0073e0193750a412eb4df01accdc
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@vicroms vicroms merged commit 857bccd into microsoft:master Mar 9, 2022
@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] Gazebo
7 participants