[nu-book-zxing-cpp] New port

[joiskash]

Describe the pull request

• What does your PR fix?

This Fixes #10503. It is a closed issue. I cannot reopen it .

• Which triplets are supported/not supported? Have you updated the CI baseline?

  It supports all but I have tried it only on x64-windows. No I have not updated the baseline.

• Does your PR follow the maintainer guide?

  Yes

• If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

  I am still working on this PR

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

[ghost]

All CLA requirements met.

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5ef52b5b75887fb150711f5effb221dd98b99e6f -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/z-/zxing-cpp.json b/versions/z-/zxing-cpp.json
index 627e129..cfdec8a 100644
--- a/versions/z-/zxing-cpp.json
+++ b/versions/z-/zxing-cpp.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "803264b5c51e6e0563a937bddc0a9d23cd399f6e",
+      "git-tree": "ed61e48b25b3d69762f58a5a3efa1c379c3b727f",
       "version-string": "2022-01",
       "port-version": 4
     },

[dg0yt]

What is it doing with git and ExternalProject? Please no hidden downloads and vendored dependencies.

[joiskash]

What is it doing with git and ExternalProject? Please no hidden downloads and vendored dependencies.

https://github.com/nu-book/zxing-cpp/blob/master/test/blackbox/CMakeLists.txt

if (NOT fmt_FOUND)
    include(FetchContent)
    FetchContent_Declare (fmtlib
            GIT_REPOSITORY https://github.com/fmtlib/fmt.git
            GIT_TAG 8.0.1)
    FetchContent_MakeAvailable (fmtlib) # Adds fmt::fmt
endif()

This is not part of the core. It is part of test/blackbox we could probably just remove it

[joiskash]

I tried to add fmt as a dependency in the manifest file, that did not help.

[dg0yt]

Thanks for the response. Apart from tests being generally skipped in vcpkg ports, it should really use vcpkg's fmt if needed.
It provides cmake config including fmt::fmt, so it must work.

Looking around, it seems that BUILD_SYSTEM_DEPS should be set to ALWAYS (actually meaning to always use system dependencies instead of vendored dependencies).
https://github.com/nu-book/zxing-cpp/blob/485a72b73fe549a623bf3cf7220c58bf6c1b1cdb/CMakeLists.txt#L11

[ras0219-msft]

Thanks for the PR!

Since:

1. This conflicts with the existing zxing-cpp port
2. The existing port has no consumers
3. The existing port is abandoned with multiple inquiries on its GitHub with no response from someone with commit access
4. This new port seems to be well maintained and listed on the main zxing page

It makes sense to remove the abandoned zxing-cpp and instead build this library in CI and promote it for vcpkg users. I've pushed a commit to do that to https://github.com/ras0219-msft/vcpkg/tree/dev/roschuma/nu-book-zxing-cpp, so please run:

git pull https://github.com/ras0219-msft/vcpkg dev/roschuma/nu-book-zxing-cpp

and push the result to this PR.

We will also discuss this on Thursday PST to confirm that we want to remove the existing zxing-cpp port.

[joiskash]

Sure I will. I have not consumed any changes from your branch yet. I thought of just waiting until the decision of keeping this as a new port or replacing the old one has been made. Thank you for your comments!

[ras0219-msft]

We have made the decision that we should add this as a new port and remove the old port.

[joiskash]

I have cherry picked the commit from your branch @ras0219-msft , let me know if anything else needs to be done.

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5e98739ce23979ac0cd19e366a9f3fd08571e183 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 4722611..62019f9 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -7564,6 +7564,10 @@
       "baseline": "2021-04-23",
       "port-version": 0
     },
+    "zxing-cpp": {
+      "baseline": "2020-12",
+      "port-version": 3
+    },
     "zydis": {
       "baseline": "3.2.1",
       "port-version": 0

[JackBoosY]

@ras0219-msft Should we rename this port to zxing-cpp?

[joiskash]

ENV{CL} "$ENV{CL} -wd4996" this did not seem to work. uwp build is failing due to error C4996

[ras0219-msft]

@ras0219-msft Should we rename this port to zxing-cpp?

No, while this library does conflict with the original zxing-cpp, it makes no attempt to be a drop-in replacement. Therefore it is inappropriate to have the name zxing-cpp refer to this library.

ENV{CL} "$ENV{CL} -wd4996" this did not seem to work. uwp build is failing due to error C4996

Let's mark this as unsupported on UWP for now. Unfortunately, we use MSBuild when targeting UWP which behaves very differently and would require patching to fix. This can be done by adding "supports": "!uwp" in the manifest file.

[joiskash]

Let's mark this as unsupported on UWP for now. Unfortunately, we use MSBuild when targeting UWP which behaves very differently and would require patching to fix. This can be done by adding "supports": "!uwp" in the manifest file.

Ok, but passing it this way DCMAKE_CXX_FLAG=-wd4996 as an OPTION to vcpkg_cmake_configure works fine. That's what I had done previously.
Either way, Im ok with not supporting uwp.
Please have a look at the portfile just before your commit.

[ras0219-msft]

Thanks and sorry for the long journey here!

[joiskash]

No problem. Im glad that my contribution got merged into main :)