Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imgui] Update to 1.87 [implot] Update to 0.13 #22988

Merged
merged 10 commits into from
Feb 15, 2022
Merged

[imgui] Update to 1.87 [implot] Update to 0.13 #22988

merged 10 commits into from
Feb 15, 2022

Conversation

RT2Code
Copy link
Contributor

@RT2Code RT2Code commented Feb 8, 2022

Update the imgui port from 1.86 to 1.87 and the implot port from 0.12 to 0.13.

Changelogs :
https://github.com/ocornut/imgui/releases/tag/v1.87
https://github.com/epezent/implot/releases/tag/v0.13

@RT2Code RT2Code changed the title [imgui] Update to 1.87 [imgui] Update to 1.87 [implot] Update to 0.13 Feb 8, 2022
@JonLiu1993 JonLiu1993 self-assigned this Feb 8, 2022
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Feb 8, 2022
@JonLiu1993
Copy link
Member

@RT222 ,Thanks for your pr, looks ci failed on x64_osx triplet,
This is error log:
install-x64-osx-dbg-out.log

@RT2Code
Copy link
Contributor Author

RT2Code commented Feb 9, 2022

I added a patch to fix this and also submitted a PR upstream : epezent/implot#322

@JonLiu1993 JonLiu1993 added depends:upstream-changes Waiting on a change to the upstream project and removed requires:author-response labels Feb 9, 2022
@RT2Code
Copy link
Contributor Author

RT2Code commented Feb 9, 2022

I have a question about how I should update this port in the future. It's not in implot goals to support pre C++11 compiler (epezent/implot#322 (comment)), but from my understanding, it's what is used to build for osx. I am completely clueless about this platform, but patching implot continually to support it doesn't seem very realistic in the long term as the library will growth and the patch will get bigger and uglier.

What is the best way to handle this? Am I mistaken and it there a way to build C++11 libraries on osx, or should we remove the support of this platform for implot?

@RT2Code RT2Code closed this Feb 10, 2022
@RT2Code RT2Code reopened this Feb 10, 2022
@RT2Code
Copy link
Contributor Author

RT2Code commented Feb 10, 2022

Nevermind, I suddenly remembered the C++ standard could simply be configured through the CMake file. 😑 (and sorry about the close, I missclicked).

@JonLiu1993 JonLiu1993 removed the depends:upstream-changes Waiting on a change to the upstream project label Feb 10, 2022
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Feb 14, 2022
@ras0219-msft ras0219-msft merged commit b164255 into microsoft:master Feb 15, 2022
@ras0219-msft
Copy link
Contributor

LGTM, thanks for the update!

@RT2Code RT2Code deleted the imgui branch February 15, 2022 01:12
ekilmer added a commit to ekilmer/vcpkg that referenced this pull request Feb 15, 2022
* master: (54 commits)
  [imgui] Update to 1.87 [implot] Update to 0.13 (microsoft#22988)
  [nu-book-zxing-cpp] New port  (microsoft#22657)
  [librabbitmq] Update to 0.11.0 (microsoft#23037)
  [doc] Add doc for `supports` expression `staticcrt` (microsoft#23079)
  [doctest] Update to 2.4.8 (microsoft#23081)
  [log4cplus] Remove unneeded catch dependency (microsoft#23066)
  [Azure SDK] Update vcpkg ports for Feb Release (microsoft#23080)
  [Freerdp] Update to 2.5.0 (microsoft#23095)
  Update vcpkg-tool to 2022-02-11 (microsoft#23059)
  Minor bugfixes to MacOS deployment readme. (microsoft#23062)
  [ci.baseline.txt] Skip colmap on osx due to metis conflict (microsoft#23047)
  [gtkmm] update to 4.6.0 (microsoft#23024)
  [faiss] Update to 1.7.2 (microsoft#22705)
  [ocilib] Disable warning C4191 (microsoft#23028)
  [polyhook2] Update to latest  (microsoft#23044)
  Add notice about how to export unofficial CMake targets. (microsoft#23041)
  [Spirv reflect] Add new port (microsoft#22295)
  [easyhook] Update target .NET Framework version to 4.7.2. (microsoft#23040)
  [gh suggestions] change license link, make it details (microsoft#22946)
  [field3d] Remove port (microsoft#22463)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants